[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #3143: [GOBBLIN-1305] Fix ORC RecordReader processing splits with offset

[GitBox <gi...@apache.org>]

ZihanLi58 commented on a change in pull request #3143:
URL: https://github.com/apache/incubator-gobblin/pull/3143#discussion_r514469164



##########
File path: gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/orc/OrcUtils.java
##########
@@ -75,10 +75,10 @@ private OrcUtils() {
 
   public static TypeDescription getTypeDescriptionFromFile(Configuration conf, Path orcFilePath)
       throws IOException {
-    return getRecordReaderFromFile(conf, orcFilePath).getSchema();
+    return getFileReader(conf, orcFilePath).getSchema();
   }
 
-  public static Reader getRecordReaderFromFile(Configuration conf, Path orcFilePath)
+  public static Reader getFileReader(Configuration conf, Path orcFilePath)

Review comment:
       Since this is a public static method, are we sure there is no other dependencies call this API?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org