You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/05/27 05:54:43 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9404: xtensa/nputs: add a mutex to prevent concurrent tasks from writing

xiaoxiang781216 commented on code in PR #9404:
URL: https://github.com/apache/nuttx/pull/9404#discussion_r1207702276


##########
arch/xtensa/src/common/xtensa_nputs.c:
##########
@@ -39,8 +40,14 @@
 
 void up_nputs(const char *str, size_t len)

Review Comment:
   since up_putc can be called in the interrupt context, and up_nputs is an accelerated version of up_putc, it's better to make up_nputc work in the interrupt handler too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org