[GitHub] [helix] kaisun2000 commented on pull request #1066: Prevent parallel controller pipelines run causing two master replicas

[GitBox <gi...@apache.org>]

kaisun2000 commented on pull request #1066:
URL: https://github.com/apache/helix/pull/1066#issuecomment-668896433


   A high level question. The following approach basically encode the session info to the data of ZkClient? Last time in the design discussion I guess people raised the concern that this mean ZkClient need to understand the data format. Normally lower level do not understand higher level data. 
   
   Though you can also think of session id in the data as meta data, just like TCP has out of line control data. 
   
   Either way is fine to me. Just want to make sure @pkuwm and @lei-xia agree with this approach. 
   
   ```
     private String parseExpectedSessionId(Object data) {
       if (!(data instanceof SessionAwareZkWriteData)) {
         return null;
       }
       return ((SessionAwareZkWriteData) data).getExpectedSessionId();
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org