You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/01/26 22:26:33 UTC

[GitHub] [ozone] umamaheswararao opened a new pull request #3021: HDDS-6083: EC: Fix flakyness of tests around nodefailures

umamaheswararao opened a new pull request #3021:
URL: https://github.com/apache/ozone/pull/3021


   ## What changes were proposed in this pull request?
   
   Fixed the tests to use a predictable way to mark the nodes fail.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-6083
   
   ## How was this patch tested?
   
   Fixed the tests to avoid flaky behaviors.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] umamaheswararao commented on pull request #3021: HDDS-6083: EC: Fix flakyness of tests around nodefailures

Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on pull request #3021:
URL: https://github.com/apache/ozone/pull/3021#issuecomment-1027461850


   Thanks @fapifta for reviewing this. Yeah NP. we need to close this before merge proposals as it states flakiness in tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] umamaheswararao commented on pull request #3021: HDDS-6083: EC: Fix flakyness of tests around nodefailures

Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on pull request #3021:
URL: https://github.com/apache/ozone/pull/3021#issuecomment-1024755275


   @fapifta please check this and let's close this JIRA once we commit. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] fapifta commented on pull request #3021: HDDS-6083: EC: Fix flakyness of tests around nodefailures

Posted by GitBox <gi...@apache.org>.
fapifta commented on pull request #3021:
URL: https://github.com/apache/ozone/pull/3021#issuecomment-1027454405


   LGTM, after removing randomness from block allocations, the flakyness of these tests should have gone already, and in the future, if we run again into the condition that caused the flakyness, we will have consistent failures.
   
   Thank you for taking care of this one, I am sorry that I could not get back to this recently after the block allocator changes.
   I am closing the other PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] umamaheswararao merged pull request #3021: HDDS-6083: EC: Fix flakyness of tests around nodefailures

Posted by GitBox <gi...@apache.org>.
umamaheswararao merged pull request #3021:
URL: https://github.com/apache/ozone/pull/3021


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org