You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/22 16:34:31 UTC
[GitHub] [airflow] crazzysun opened a new pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements
crazzysun opened a new pull request #8975:
URL: https://github.com/apache/airflow/pull/8975
Issue #8969
- Create an Airflow operator atlas entity don't use execution date as part of the qualified name anymore.
- Add config property for enabled/disabled creating missing inlets, outlets entities.
- Add config property for enabled/disabled falling operator if sending lineage was failed
- Add atlas timeout config property.
- Add "template_fields" into the airflow operator typedef and add additional config property for setting any additional operator attributes.
- Fix DataSet class wrapper, add abstract types for file and JDBC source.
- Added utils methods for correct generating inlets and outlet objects.
- Added unit tests for creating missing entities and falling operators.
PR based on v1-10-stable Atlas backend ([link to PR to a v-1-10-stable branch of my fork](https://github.com/crazzysun/airflow/pull/1)).
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #8975:
URL: https://github.com/apache/airflow/pull/8975#issuecomment-632788174
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #8975:
URL: https://github.com/apache/airflow/pull/8975#issuecomment-640219191
I am afraid that the most active reviewers are not familiar with Lineage. Therefore, you must find a person who can review this change. To do this, you must write a message on the mailing list. If this message is seen by a person who knows lineage, then you can go on. However, if no such person is found, then you need to find the latest discussion on the mailing list and write a private message asking for reviews Airflow is a community managed project and communication with other members of this community is an important part of it. We don't have any paid employees who handle pull requests. All work is based on volunteering or the involvement of companies that want to develop this project.
I hope this information will be helpful to you. if you have questions please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #8975:
URL: https://github.com/apache/airflow/pull/8975#issuecomment-670836655
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] thibaultbl commented on pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements
Posted by GitBox <gi...@apache.org>.
thibaultbl commented on pull request #8975:
URL: https://github.com/apache/airflow/pull/8975#issuecomment-970417619
Do you have any idea if Apache Atlas Lineage Backend will be reinstated anytime soon ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] closed pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #8975:
URL: https://github.com/apache/airflow/pull/8975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #8975:
URL: https://github.com/apache/airflow/pull/8975#issuecomment-646964430
@bolkedebruin thanks for the message. I will engage you in the changes related to this area.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bolkedebruin commented on pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements
Posted by GitBox <gi...@apache.org>.
bolkedebruin commented on pull request #8975:
URL: https://github.com/apache/airflow/pull/8975#issuecomment-646964253
I'm having a look @mik-laj it remains an important area and more peopl are picking it up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bolkedebruin edited a comment on pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements
Posted by GitBox <gi...@apache.org>.
bolkedebruin edited a comment on pull request #8975:
URL: https://github.com/apache/airflow/pull/8975#issuecomment-646964253
I'm having a look @mik-laj it remains an important area and more peopl are picking it up.
Note @crazzysun this code uses the old api/pattern which won't be supported anymore. The backend will be reinstated but requires refactoring. Datasets will not be used anymore as it wasn't scaleable. See the current code in master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org