You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/01 00:45:01 UTC

[GitHub] [beam] yifanmai commented on a change in pull request #13432: [BEAM-11355] Fix topological ordering of pipeline_from_stages after sort_stages

yifanmai commented on a change in pull request #13432:
URL: https://github.com/apache/beam/pull/13432#discussion_r532998267



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -557,8 +557,13 @@ def add_parent(child, parent):
             pipeline_proto.components.transforms[parent])
         copy_output_pcollections(components.transforms[parent])
         del components.transforms[parent].subtransforms[:]
-        add_parent(parent, parents.get(parent))
+      # Ensure that child is the lsat item in the parent's subtransforms.

Review comment:
       Thanks for catching; fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org