You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/18 07:29:45 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #21658: Disable default_pool delete on web ui

uranusjr commented on a change in pull request #21658:
URL: https://github.com/apache/airflow/pull/21658#discussion_r809736263



##########
File path: airflow/models/pool.py
##########
@@ -84,6 +84,18 @@ def get_default_pool(session: Session = NEW_SESSION):
         """
         return Pool.get_pool(Pool.DEFAULT_POOL_NAME, session=session)
 
+    @staticmethod
+    @provide_session
+    def is_default_pool(id: str, session: Session = NEW_SESSION):

Review comment:
       This doesn’t look right? `id` is an integer at the database level, not a `str`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org