[Bug 55006] Add http proxy support for ClientEndpoint using system properties

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=55006

--- Comment #3 from Konstantin Kolinko <kn...@gmail.com> ---
(In reply to Mark Thomas from comment #2)
> Generally, I dislike using system properties for any kind of configuration.

I do as well.

How about using ClientEndpointConfig.getUserProperties() to pass those?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: [Bug 55006] Add http proxy support for ClientEndpoint using system properties

[Christopher Schultz <ch...@christopherschultz.net>]

Niki,

Perhaps you should put some of this discussion into the Bugzilla issue
so it can be tracked more easily by anyone interested in the progress.

-chris

On 6/4/13 1:55 AM, Niki Dokovski wrote:
> On Tue, Jun 4, 2013 at 12:01 AM, Rossen Stoyanchev <
> rstoyanchev@gopivotal.com> wrote:
> 
>> On Mon, Jun 3, 2013 at 10:27 AM, Niki Dokovski <ni...@gmail.com> wrote:
>>
>>> On Mon, Jun 3, 2013 at 3:44 PM, Niki Dokovski <ni...@gmail.com>
>> wrote:Further
>>> on, if you choose to use connectToServer call that has the
>>> ClientEndpointConfig param you are losing the annotation approach as the
>>> first param of this call has to be an instance of an Endpoint. Hence your
>>> class can not be just annotated. hmmm Mark where can we bring this
>>> discussion?
>>
>>
>> This is not very obvious from the API but ClientEndpointConfig (and
>> ServerEndpointConfig) are not meant to be used with annotated endpoints. In
>> other words, I think the methods accepting those types are for use with
>> type-based endpoints (i.e. javax.websocket.Endpoint). So as far as I can
>> see user properties can be updated before the session starts only for
>> type-based endpoints.
>>
> 
> Exactly, What is the rationale behind this?
> Still an annotated endpoint can supply
> javax.websocket.ClientEndpointConfig.Configurator
> but has no access to the user properties from there. May be the
> javax.websocket.ClientEndpointConfig.Configurator
> can be extended to provide access to the map.
> 
> cheers
> 
> 
>>
>> Rossen
>>
> 

Re: [Bug 55006] Add http proxy support for ClientEndpoint using system properties

[Niki Dokovski <ni...@gmail.com>]

On Tue, Jun 4, 2013 at 12:01 AM, Rossen Stoyanchev <
rstoyanchev@gopivotal.com> wrote:

> On Mon, Jun 3, 2013 at 10:27 AM, Niki Dokovski <ni...@gmail.com> wrote:
>
> > On Mon, Jun 3, 2013 at 3:44 PM, Niki Dokovski <ni...@gmail.com>
> wrote:Further
> > on, if you choose to use connectToServer call that has the
> > ClientEndpointConfig param you are losing the annotation approach as the
> > first param of this call has to be an instance of an Endpoint. Hence your
> > class can not be just annotated. hmmm Mark where can we bring this
> > discussion?
>
>
> This is not very obvious from the API but ClientEndpointConfig (and
> ServerEndpointConfig) are not meant to be used with annotated endpoints. In
> other words, I think the methods accepting those types are for use with
> type-based endpoints (i.e. javax.websocket.Endpoint). So as far as I can
> see user properties can be updated before the session starts only for
> type-based endpoints.
>

Exactly, What is the rationale behind this?
Still an annotated endpoint can supply
javax.websocket.ClientEndpointConfig.Configurator
but has no access to the user properties from there. May be the
javax.websocket.ClientEndpointConfig.Configurator
can be extended to provide access to the map.

cheers


>
> Rossen
>

Re: [Bug 55006] Add http proxy support for ClientEndpoint using system properties

[Rossen Stoyanchev <rs...@gopivotal.com>]

On Mon, Jun 3, 2013 at 10:27 AM, Niki Dokovski <ni...@gmail.com> wrote:

> On Mon, Jun 3, 2013 at 3:44 PM, Niki Dokovski <ni...@gmail.com> wrote:Further
> on, if you choose to use connectToServer call that has the
> ClientEndpointConfig param you are losing the annotation approach as the
> first param of this call has to be an instance of an Endpoint. Hence your
> class can not be just annotated. hmmm Mark where can we bring this
> discussion?


This is not very obvious from the API but ClientEndpointConfig (and
ServerEndpointConfig) are not meant to be used with annotated endpoints. In
other words, I think the methods accepting those types are for use with
type-based endpoints (i.e. javax.websocket.Endpoint). So as far as I can
see user properties can be updated before the session starts only for
type-based endpoints.

Rossen

Re: [Bug 55006] Add http proxy support for ClientEndpoint using system properties

[Niki Dokovski <ni...@gmail.com>]

On Mon, Jun 3, 2013 at 3:44 PM, Niki Dokovski <ni...@gmail.com> wrote:

>
>
>
> On Mon, Jun 3, 2013 at 3:13 PM, <bu...@apache.org> wrote:
>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55006
>>
>> --- Comment #3 from Konstantin Kolinko <kn...@gmail.com> ---
>> (In reply to Mark Thomas from comment #2)
>> > Generally, I dislike using system properties for any kind of
>> configuration.
>>
>> I do as well.
>>
>> How about using ClientEndpointConfig.getUserProperties() to pass those?
>>
>
> +1
> In general, I'm fine with any proposal that removes the limitation. Just
> hope that JSR 356 EG won't wait for Java EE 8 to come up with an update.
>  Meanwhile people can use current patch. Or we can craft something based on
> user configurations in ClientEndpoint leveraging Mark's ProxySelector. I'll
> give it a try...
>
> cheers
>

At first look,  It turned to be a bit challenging of how to get to the
modifiable user properties map if you work only with annotated class.

Just created another bug for the spec. (The javadoc in one of the
connectToServer methods should be changed as it states that the supplied
object should be annotated with ServerEndpoint where it actually should be
annotated with ClientEndpoint.
https://java.net/jira/browse/WEBSOCKET_SPEC-206


Further on, if you choose to use connectToServer call that has the
ClientEndpointConfig param you are losing the annotation approach as the
first param of this call has to be an instance of an Endpoint. Hence your
class can not be just annotated. hmmm Mark where can we bring this
discussion?




>
>> --
>> You are receiving this mail because:
>> You are the assignee for the bug.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>

Re: [Bug 55006] Add http proxy support for ClientEndpoint using system properties

[Niki Dokovski <ni...@gmail.com>]

On Mon, Jun 3, 2013 at 3:13 PM, <bu...@apache.org> wrote:

> https://issues.apache.org/bugzilla/show_bug.cgi?id=55006
>
> --- Comment #3 from Konstantin Kolinko <kn...@gmail.com> ---
> (In reply to Mark Thomas from comment #2)
> > Generally, I dislike using system properties for any kind of
> configuration.
>
> I do as well.
>
> How about using ClientEndpointConfig.getUserProperties() to pass those?
>

+1
In general, I'm fine with any proposal that removes the limitation. Just
hope that JSR 356 EG won't wait for Java EE 8 to come up with an update.
 Meanwhile people can use current patch. Or we can craft something based on
user configurations in ClientEndpoint leveraging Mark's ProxySelector. I'll
give it a try...

cheers

>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>