You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/11 10:30:03 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #6538: resolve "receiver don't need to get itself when healthCheck #6515 "

wu-sheng commented on a change in pull request #6538:
URL: https://github.com/apache/skywalking/pull/6538#discussion_r592242807



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cluster/OAPNodeChecker.java
##########
@@ -28,6 +30,9 @@
 public class OAPNodeChecker {
     private static final Set<String> ILLEGAL_NODE_ADDRESS_IN_CLUSTER_MODE = Sets.newHashSet("127.0.0.1", "localhost");
 
+    @Setter
+    private static String ROLE;

Review comment:
       I think it is better to set a default value of this. And use enum rather than `enum Role` rather than string.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org