You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/04/11 11:02:49 UTC
Review Request 46015: Stout:[2/2] Moved process tests to their own
file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46015/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-4471
https://issues.apache.org/jira/browse/MESOS-4471
Repository: mesos
Description
-------
Stout:[2/2] Moved process tests to their own file.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 217283cd3ce6df699b63dc5b8fb3aab0c6debd04
Diff: https://reviews.apache.org/r/46015/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 46015: Stout:[2/2] Moved process tests to their
own file.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46015/#review128152
-----------------------------------------------------------
Bad patch!
Reviews applied: [46015, 46014, 46013, 46012, 43985]
Failed command: ./support/apply-review.sh -n -r 43985
Error:
2016-04-11 16:40:00 URL:https://reviews.apache.org/r/43985/diff/raw/ [1185/1185] -> "43985.patch" [1]
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp:36: Missing space after , [whitespace/comma] [3]
Total errors found: 1
Checking 1 files
Full log: https://builds.apache.org/job/mesos-reviewbot/12461/console
- Mesos ReviewBot
On April 11, 2016, 9:02 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46015/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 9:02 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout:[2/2] Moved process tests to their own file.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 217283cd3ce6df699b63dc5b8fb3aab0c6debd04
>
> Diff: https://reviews.apache.org/r/46015/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 46015: Stout:[2/2] Moved process tests to their
own file.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46015/#review128995
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On April 11, 2016, 9:02 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46015/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 9:02 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout:[2/2] Moved process tests to their own file.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 217283cd3ce6df699b63dc5b8fb3aab0c6debd04
>
> Diff: https://reviews.apache.org/r/46015/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>