[GitHub] [geode] onichols-pivotal opened a new pull request #6972: GEODE-9629: previous fix missed removing this other public getter

[GitBox <gi...@apache.org>]

onichols-pivotal opened a new pull request #6972:
URL: https://github.com/apache/geode/pull/6972


   first fix #6915 removed the errant setter.  this fix removes the getter.
   
   adding new methods to a public interface like GatewaySender is a breaking change for other implementations of this interface, such as in Spring Data Geode project.  We can consider bringing these only when a new major is proposed (e.g. Geode 2.0)
   
   All of the Geode code that uses this getter already uses AbstractGatewaySender anyway, so the easiest fix is just to push this down for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] onichols-pivotal merged pull request #6972: GEODE-9629: previous fix missed removing this other public getter

[GitBox <gi...@apache.org>]

onichols-pivotal merged pull request #6972:
URL: https://github.com/apache/geode/pull/6972


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org