You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/06/03 18:01:25 UTC

[GitHub] [netbeans] BradWalker commented on a change in pull request #1277: [NETBEANS-2621] cleanup generic class iterator

BradWalker commented on a change in pull request #1277: [NETBEANS-2621] cleanup generic class iterator
URL: https://github.com/apache/netbeans/pull/1277#discussion_r289966029
 
 

 ##########
 File path: platform/openide.filesystems/src/org/openide/filesystems/MultiFileObject.java
 ##########
 @@ -205,7 +205,6 @@ private void update() {
         }
 
         Iterator it = now.iterator();
-
         while (it.hasNext()) {
             FileObject fo = (FileObject) it.next();
 
 Review comment:
   Unfortunately it not "low hanging fruit".. When I change this to the foreach pattern, I get the following error message..
   
   ```
      [repeat] /home/bwalker/netbeans-11.0/platform/openide.filesystems/src/org/openide/filesystems/MultiFileObject.java:207: error: incompatible types: Object cannot be converted to FileObject
      [repeat]         for (FileObject fo : now) {
      [repeat] 
   ```                             ^
   So I left it out..
   
   My goal is simply to get the build warnings down..
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists