You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by 979969786 <gi...@git.apache.org> on 2015/09/09 12:13:04 UTC
[GitHub] phoenix pull request: PHOENIX-2238 Support more delimiter when usi...
GitHub user 979969786 opened a pull request:
https://github.com/apache/phoenix/pull/116
PHOENIX-2238 Support more delimiter when using CsvBulkImport
Add a function to support more delimiter when using CsvBulkImport, such as /001, /t, /n.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/979969786/phoenix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 53992542040bde33a8f3f93560adaac007b353c6
Author: yuming.wang <q7...@gmail.com>
Date: 2015-09-09T10:05:45Z
support more delimiter when using CsvBulkImport
Add a function to support more delimiter when using CsvBulkImport, such as /001, /t.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2238 Support more delimiter when usi...
Posted by gabrielreid <gi...@git.apache.org>.
Github user gabrielreid commented on the pull request:
https://github.com/apache/phoenix/pull/116#issuecomment-139287029
I think that this is an interesting idea, but did you see my comment on [PHOENIX-2238](https://issues.apache.org/jira/browse/PHOENIX-2238)? There is support built in to the shell which allows you to supply non-printable characters.
I can see how this might be more user-friendly for some, while being confusing for others (who are already familiar with the standard method of providing non-printable characters on the command line).
Another concern that I have is that providing these kinds of literals that start with backslashes also require some understanding about the rules of escaping when supplying command line parameters, so this kind of makes me think that it might be better to go completely for expecting users to know how to work with the shell properly.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2238 Support more delimiter when usi...
Posted by 979969786 <gi...@git.apache.org>.
Github user 979969786 closed the pull request at:
https://github.com/apache/phoenix/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---