You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/01 08:05:14 UTC
[GitHub] [pulsar] fmiguelez opened a new pull request #7408: [Issue 7407] Support for tombstones (null value in messages) does not work
fmiguelez opened a new pull request #7408:
URL: https://github.com/apache/pulsar/pull/7408
Added check to prevent NPE when a tombstone (null value) is produced.
Master Issue: #7407
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
Null value check
### Verifying this change
Tests are provided in #7407. Some similar tests should be integrated into Pulsar code when final solution is presented.
### Does this pull request potentially affect one of the following parts:
No
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
- If a feature is not applicable for documentation, explain why? (null check)
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #7408: [Issue 7407] Support for tombstones (null value in messages) does not work
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7408:
URL: https://github.com/apache/pulsar/pull/7408
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7408: [Issue 7407] Support for tombstones (null value in messages) does not work
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7408:
URL: https://github.com/apache/pulsar/pull/7408#issuecomment-652501541
@gaoran10 @nlu90 Would you please also help review this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7408: [Issue 7407] Support for tombstones (null value in messages) does not work
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7408:
URL: https://github.com/apache/pulsar/pull/7408#issuecomment-652780499
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org