You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/14 04:02:26 UTC

[GitHub] [flink] wuchong edited a comment on pull request #12130: [FLINK-17668][table] Fix shortcomings in new data structures

wuchong edited a comment on pull request #12130:
URL: https://github.com/apache/flink/pull/12130#issuecomment-628372183


   Btw, I have a simple benchmark to compare the performance of get utitilty and the get accessor. 
   
   The result shows get accessor is slightly worse than get utility:
   
   ```
   # Run complete. Total time: 00:03:36
   
   Benchmark                   Mode  Cnt     Score     Error   Units
   RowBenchmark.testAccessor  thrpt   20  4656.362 ± 355.096  ops/ms
   RowBenchmark.testUtility   thrpt   20  4933.103 ± 655.208  ops/ms
   ```
   
   Here is the code, maybe the virtual function call is the reason. Or I did something wrong and missed something. 
   https://github.com/wuchong/my-benchmark/blob/master/src/main/java/myflink/RowBenchmark.java


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org