You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by ra...@apache.org on 2009/07/24 02:11:21 UTC
svn commit: r797274 - in /hadoop/common/trunk: CHANGES.txt
src/java/org/apache/hadoop/io/file/tfile/TFile.java
Author: rangadi
Date: Fri Jul 24 00:11:20 2009
New Revision: 797274
URL: http://svn.apache.org/viewvc?rev=797274&view=rev
Log:
HADOOP-6150. Users should be able to instantiate comparator using TFile
API. (Hong Tang via rangadi)
Modified:
hadoop/common/trunk/CHANGES.txt
hadoop/common/trunk/src/java/org/apache/hadoop/io/file/tfile/TFile.java
Modified: hadoop/common/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/CHANGES.txt?rev=797274&r1=797273&r2=797274&view=diff
==============================================================================
--- hadoop/common/trunk/CHANGES.txt (original)
+++ hadoop/common/trunk/CHANGES.txt Fri Jul 24 00:11:20 2009
@@ -891,6 +891,9 @@
HADOOP-6132. RPC client create an extra connection because of incorrect
key for connection cache. (Kan Zhang via rangadi)
+ HADOOP-6150. Users should be able to instantiate comparator using TFile
+ API. (Hong Tang via rangadi)
+
Release 0.20.1 - Unreleased
INCOMPATIBLE CHANGES
Modified: hadoop/common/trunk/src/java/org/apache/hadoop/io/file/tfile/TFile.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/src/java/org/apache/hadoop/io/file/tfile/TFile.java?rev=797274&r1=797273&r2=797274&view=diff
==============================================================================
--- hadoop/common/trunk/src/java/org/apache/hadoop/io/file/tfile/TFile.java (original)
+++ hadoop/common/trunk/src/java/org/apache/hadoop/io/file/tfile/TFile.java Fri Jul 24 00:11:20 2009
@@ -161,6 +161,17 @@
/** comparator prefix: java class */
public static final String COMPARATOR_JCLASS = "jclass:";
+ /**
+ * Make a raw comparator from a string name.
+ *
+ * @param name
+ * Comparator name
+ * @return A RawComparable comparator.
+ */
+ static public Comparator<RawComparable> makeComparator(String name) {
+ return TFileMeta.makeComparator(name);
+ }
+
// Prevent the instantiation of TFiles
private TFile() {
// nothing
@@ -1947,7 +1958,7 @@
}
@SuppressWarnings("unchecked")
- private static BytesComparator makeComparator(String comparator) {
+ static BytesComparator makeComparator(String comparator) {
if (comparator.length() == 0) {
// unsorted keys
return null;