You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/11/05 19:38:05 UTC

(commons-lang) branch master updated: Make private class final

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new 6dc61ad80 Make private class final
6dc61ad80 is described below

commit 6dc61ad800695b6d2f682d6914b376a2d08c60e3
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 5 14:37:59 2023 -0500

    Make private class final
---
 .../java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java | 2 +-
 src/main/java/org/apache/commons/lang3/time/FastDateParser.java         | 2 +-
 src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java              | 2 +-
 src/test/java/org/apache/commons/lang3/ClassUtilsTest.java              | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java b/src/main/java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java
index 1fb68e488..a8943da93 100644
--- a/src/main/java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java
+++ b/src/main/java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java
@@ -122,7 +122,7 @@ public class BackgroundInitializer<T> extends AbstractConcurrentInitializer<T, E
 
     }
 
-    private class InitializationTask implements Callable<T> {
+    private final class InitializationTask implements Callable<T> {
         /** Stores the executor service to be destroyed at the end. */
         private final ExecutorService execFinally;
 
diff --git a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
index 89aac5804..c87abe936 100644
--- a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
+++ b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
@@ -418,7 +418,7 @@ public class FastDateParser implements DateParser, Serializable {
     /**
      * Parse format into Strategies
      */
-    private class StrategyParser {
+    private final class StrategyParser {
         private final Calendar definingCalendar;
         private int currentIdx;
 
diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
index 826ec6f22..400cb7907 100644
--- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
@@ -45,7 +45,7 @@ import org.junit.jupiter.api.Test;
 @SuppressWarnings("deprecation") // deliberate use of deprecated code
 public class ArrayUtilsTest extends AbstractLangTest {
 
-    private class TestClass {
+    private final class TestClass {
         // empty
     }
 
diff --git a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
index c79db8773..c77702b01 100644
--- a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
@@ -86,7 +86,7 @@ public class ClassUtilsTest extends AbstractLangTest {
     }
 
     private static final class Inner {
-        private class DeeplyNested {
+        private final class DeeplyNested {
             // empty
         }
     }