[GitHub] [samza] cameronlee314 commented on a change in pull request #1018: Adding tests for legacy store offset file

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #1018: Adding tests for legacy store offset file
URL: https://github.com/apache/samza/pull/1018#discussion_r280552343
 
 

 ##########
 File path: samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala
 ##########
 @@ -711,6 +739,17 @@ class TestTaskStorageManager extends MockitoSugar {
   }
 }
 
+object TestTaskStorageManager {
+
+  @Parameters def parameters: util.Collection[Array[String]] = {
+    val offsetFileNames = new util.ArrayList[Array[String]]()
+    offsetFileNames.add(Array(StorageManagerUtil.OFFSET_FILE_NAME_NEW))
 
 Review comment:
   Is there a test which ensures that if both files exist, then only the NEW one is used?
   You might already have a test for this somewhere, but wanted to double check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services