You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by rmatharu <gi...@git.apache.org> on 2019/01/16 01:17:25 UTC

[GitHub] samza pull request #882: DiagnosticsAppender for log4j2

GitHub user rmatharu opened a pull request:

    https://github.com/apache/samza/pull/882

    DiagnosticsAppender for log4j2

    This PR adds a DiagnosticsAppender for log4j2. 
    There exists one already for log4j in samza-log4j. 
    
    However the Appender, LogEvent, and Configuration APIs between log4j2 and log4j are completely different. 
    So there was very little overlap (and very little value) in creating a base-class for the two appenders. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmatharu/samza log4j2appender

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/882.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #882
    
----
commit 0212d4dc40e80f07c05b0d7b0fdc2d0491f941d3
Author: Ray Matharu <rm...@...>
Date:   2019-01-16T01:14:29Z

    Adding DiagnosticsAppender for log4j2

----


---

[GitHub] samza pull request #882: DiagnosticsAppender for log4j2

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/882


---