You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (Jira)" <ji...@apache.org> on 2020/07/01 09:59:00 UTC
[jira] [Commented] (OFBIZ-11489) Convert cancelPaymentBatch service
from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149260#comment-17149260 ]
Jacques Le Roux commented on OFBIZ-11489:
-----------------------------------------
Hi Kirti,
Rather than using
{{if (ServiceUtil.isError(result)) return result}}
would it not be better to use
{{return error(serviceResult)}}?
Also when the service succeed you should return {{return success()}}
The rest sounds good to me
> Convert cancelPaymentBatch service from mini-lang to groovy DSL
> ---------------------------------------------------------------
>
> Key: OFBIZ-11489
> URL: https://issues.apache.org/jira/browse/OFBIZ-11489
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: Trunk
> Reporter: Devanshu Vyas
> Assignee: Kirti Arora
> Priority: Minor
> Attachments: OFBIZ-11489.patch, OFBIZ-11489.patch, OFBIZ-11489.patch
>
>
> Convert the cancelPaymentBatch service code from mini-lang to groovy DSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)