You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ripple.apache.org by br...@apache.org on 2015/04/22 16:42:26 UTC

[1/2] incubator-ripple git commit: There was some lint in the build archive module.

Repository: incubator-ripple
Updated Branches:
  refs/heads/master f59e16ebd -> ded244aca


There was some lint in the build archive module.


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/d935ba9a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/d935ba9a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/d935ba9a

Branch: refs/heads/master
Commit: d935ba9a27ad4e84cdb41dd4fbd088a713da500f
Parents: f59e16e
Author: Brent Lintner <br...@gmail.com>
Authored: Tue Apr 21 10:36:36 2015 -0400
Committer: Brent Lintner <br...@gmail.com>
Committed: Wed Apr 22 10:34:16 2015 -0400

----------------------------------------------------------------------
 build/archive.js | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/d935ba9a/build/archive.js
----------------------------------------------------------------------
diff --git a/build/archive.js b/build/archive.js
index 2674aed..0b439ec 100644
--- a/build/archive.js
+++ b/build/archive.js
@@ -229,8 +229,13 @@ function exec(cmdLine, baton, callback) {
     }
 
     child_process.exec(cmdLine, function (err, stdout, stderr) {
-        var err = err || stderr;
-        err && baton ? error(err, baton) : callback((stdout || '').trim(), err);
+        err = err || stderr;
+
+        if (err && baton) {
+            error(err, baton);
+        } else {
+            callback((stdout || '').trim(), err);
+        }
     });
 }
 
@@ -246,7 +251,7 @@ function error(msg, baton) {
         usage();
     }
 
-    baton && baton.drop({failed: true});
+    if (baton) { baton.drop({failed: true}); }
 }
 
 function usage(includeIntro) {


[2/2] incubator-ripple git commit: There was some lint in a client file.

Posted by br...@apache.org.
There was some lint in a client file.


Project: http://git-wip-us.apache.org/repos/asf/incubator-ripple/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ripple/commit/ded244ac
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ripple/tree/ded244ac
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ripple/diff/ded244ac

Branch: refs/heads/master
Commit: ded244acaa3f4788a7b526b4180acb5dd42aaa48
Parents: d935ba9
Author: Brent Lintner <br...@gmail.com>
Authored: Tue Apr 21 10:40:08 2015 -0400
Committer: Brent Lintner <br...@gmail.com>
Committed: Wed Apr 22 10:34:18 2015 -0400

----------------------------------------------------------------------
 lib/client/utils.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ripple/blob/ded244ac/lib/client/utils.js
----------------------------------------------------------------------
diff --git a/lib/client/utils.js b/lib/client/utils.js
index c0ded63..1bb5bad 100644
--- a/lib/client/utils.js
+++ b/lib/client/utils.js
@@ -51,12 +51,12 @@ self = module.exports = {
 
         switch (argType) {
         case "array":
-            if (!arg instanceof Array) {
+            if (!(arg instanceof Array)) {
                 invalidArg = true;
             }
             break;
         case "date":
-            if (!arg instanceof Date) {
+            if (!(arg instanceof Date)) {
                 invalidArg = true;
             }
             break;