[GitHub] [incubator-paimon] MonsterChenzhuo commented on a diff in pull request #1927: [core] Fix method references may be null

["MonsterChenzhuo (via GitHub)" <gi...@apache.org>]

MonsterChenzhuo commented on code in PR #1927:
URL: https://github.com/apache/incubator-paimon/pull/1927#discussion_r1311387071


##########
paimon-core/src/main/java/org/apache/paimon/table/system/CatalogOptionsTable.java:
##########
@@ -167,14 +166,14 @@ public TableRead withIOManager(IOManager ioManager) {
         }
 
         @Override
-        public RecordReader<InternalRow> createReader(Split split) throws IOException {
+        public RecordReader<InternalRow> createReader(Split split) {
             if (!(split instanceof CatalogOptionsTable.CatalogOptionsSplit)) {
                 throw new IllegalArgumentException("Unsupported split: " + split.getClass());
             }
             Iterator<InternalRow> rows =
                     Iterators.transform(
                             ((CatalogOptionsSplit) split).catalogOptions.entrySet().iterator(),
-                            this::toRow);
+                            entry -> (entry == null) ? null : this.toRow(entry));

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org