You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Mike Tutkowski <mi...@solidfire.com> on 2013/06/28 16:30:13 UTC
AttachVolumeCommand no longer in use?
Hi,
I've been trying to reconcile a ton of changes that were merged in this
week.
We used to pass an AttachVolumeCommand to CitrixResourceBase, but now it's
called AttachCommand and CitrixResourceBase doesn't know anything about it
(this merge issue is in VolumeManagerImpl).
I'm a bit confused at the moment on how to handle this merge issue.
Does anyone know anything about this change?
Thanks!
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*™*
Re: AttachVolumeCommand no longer in use?
Posted by Mike Tutkowski <mi...@solidfire.com>.
Oh, yeah, to clarify, I just meant I need to continue to merge these large
changes into my code and then re-test my code before I commit it.
On Fri, Jun 28, 2013 at 9:23 AM, Donal Lafferty
<do...@citrix.com>wrote:
> Merge. AFAIK, it's already merged to Master
>
> Retest? I'm out of the loop. I'm working on adding Hyper-V to Master,
> and not the current release.
>
>
> > -----Original Message-----
> > From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> > Sent: 28 June 2013 3:57 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: AttachVolumeCommand no longer in use?
> >
> > So, basically, it could take a while to merge and re-test this.
> >
> > This week has been kind of a mess with all of the merges.
> >
> > Do you know if we have the weekend to tie up loose ends?
> >
> >
> > On Fri, Jun 28, 2013 at 8:55 AM, Donal Lafferty
> > <do...@citrix.com>wrote:
> >
> > > Yeah, I noticed that as well.
> > >
> > > The implementation of AttachCommand is in XenServerStorageProcessor.
> > > Look for handleStorageCommands in CitrixResourceBase.
> > >
> > > Also, could you send me a JSON encoded version of the command?
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> > > > Sent: 28 June 2013 3:30 PM
> > > > To: John Burwell; dev@cloudstack.apache.org
> > > > Subject: AttachVolumeCommand no longer in use?
> > > >
> > > > Hi,
> > > >
> > > > I've been trying to reconcile a ton of changes that were merged in
> > > > this
> > > week.
> > > >
> > > > We used to pass an AttachVolumeCommand to CitrixResourceBase, but
> > > > now it's called AttachCommand and CitrixResourceBase doesn't know
> > > > anything about it (this merge issue is in VolumeManagerImpl).
> > > >
> > > > I'm a bit confused at the moment on how to handle this merge issue.
> > > >
> > > > Does anyone know anything about this change?
> > > >
> > > > Thanks!
> > > >
> > > > --
> > > > *Mike Tutkowski*
> > > > *Senior CloudStack Developer, SolidFire Inc.*
> > > > e: mike.tutkowski@solidfire.com
> > > > o: 303.746.7302
> > > > Advancing the way the world uses the
> > > > cloud<http://solidfire.com/solution/overview/?video=play>
> > > > *(tm)*
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkowski@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud<http://solidfire.com/solution/overview/?video=play>
> > *(tm)*
>
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*™*
RE: AttachVolumeCommand no longer in use?
Posted by Donal Lafferty <do...@citrix.com>.
Merge. AFAIK, it's already merged to Master
Retest? I'm out of the loop. I'm working on adding Hyper-V to Master, and not the current release.
> -----Original Message-----
> From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> Sent: 28 June 2013 3:57 PM
> To: dev@cloudstack.apache.org
> Subject: Re: AttachVolumeCommand no longer in use?
>
> So, basically, it could take a while to merge and re-test this.
>
> This week has been kind of a mess with all of the merges.
>
> Do you know if we have the weekend to tie up loose ends?
>
>
> On Fri, Jun 28, 2013 at 8:55 AM, Donal Lafferty
> <do...@citrix.com>wrote:
>
> > Yeah, I noticed that as well.
> >
> > The implementation of AttachCommand is in XenServerStorageProcessor.
> > Look for handleStorageCommands in CitrixResourceBase.
> >
> > Also, could you send me a JSON encoded version of the command?
> >
> >
> >
> > > -----Original Message-----
> > > From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> > > Sent: 28 June 2013 3:30 PM
> > > To: John Burwell; dev@cloudstack.apache.org
> > > Subject: AttachVolumeCommand no longer in use?
> > >
> > > Hi,
> > >
> > > I've been trying to reconcile a ton of changes that were merged in
> > > this
> > week.
> > >
> > > We used to pass an AttachVolumeCommand to CitrixResourceBase, but
> > > now it's called AttachCommand and CitrixResourceBase doesn't know
> > > anything about it (this merge issue is in VolumeManagerImpl).
> > >
> > > I'm a bit confused at the moment on how to handle this merge issue.
> > >
> > > Does anyone know anything about this change?
> > >
> > > Thanks!
> > >
> > > --
> > > *Mike Tutkowski*
> > > *Senior CloudStack Developer, SolidFire Inc.*
> > > e: mike.tutkowski@solidfire.com
> > > o: 303.746.7302
> > > Advancing the way the world uses the
> > > cloud<http://solidfire.com/solution/overview/?video=play>
> > > *(tm)*
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud<http://solidfire.com/solution/overview/?video=play>
> *(tm)*
Re: AttachVolumeCommand no longer in use?
Posted by Mike Tutkowski <mi...@solidfire.com>.
So, basically, it could take a while to merge and re-test this.
This week has been kind of a mess with all of the merges.
Do you know if we have the weekend to tie up loose ends?
On Fri, Jun 28, 2013 at 8:55 AM, Donal Lafferty
<do...@citrix.com>wrote:
> Yeah, I noticed that as well.
>
> The implementation of AttachCommand is in XenServerStorageProcessor. Look
> for handleStorageCommands in CitrixResourceBase.
>
> Also, could you send me a JSON encoded version of the command?
>
>
>
> > -----Original Message-----
> > From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> > Sent: 28 June 2013 3:30 PM
> > To: John Burwell; dev@cloudstack.apache.org
> > Subject: AttachVolumeCommand no longer in use?
> >
> > Hi,
> >
> > I've been trying to reconcile a ton of changes that were merged in this
> week.
> >
> > We used to pass an AttachVolumeCommand to CitrixResourceBase, but now
> > it's called AttachCommand and CitrixResourceBase doesn't know anything
> > about it (this merge issue is in VolumeManagerImpl).
> >
> > I'm a bit confused at the moment on how to handle this merge issue.
> >
> > Does anyone know anything about this change?
> >
> > Thanks!
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkowski@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud<http://solidfire.com/solution/overview/?video=play>
> > *(tm)*
>
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud<http://solidfire.com/solution/overview/?video=play>
*™*
RE: AttachVolumeCommand no longer in use?
Posted by Donal Lafferty <do...@citrix.com>.
Yeah, I noticed that as well.
The implementation of AttachCommand is in XenServerStorageProcessor. Look for handleStorageCommands in CitrixResourceBase.
Also, could you send me a JSON encoded version of the command?
> -----Original Message-----
> From: Mike Tutkowski [mailto:mike.tutkowski@solidfire.com]
> Sent: 28 June 2013 3:30 PM
> To: John Burwell; dev@cloudstack.apache.org
> Subject: AttachVolumeCommand no longer in use?
>
> Hi,
>
> I've been trying to reconcile a ton of changes that were merged in this week.
>
> We used to pass an AttachVolumeCommand to CitrixResourceBase, but now
> it's called AttachCommand and CitrixResourceBase doesn't know anything
> about it (this merge issue is in VolumeManagerImpl).
>
> I'm a bit confused at the moment on how to handle this merge issue.
>
> Does anyone know anything about this change?
>
> Thanks!
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud<http://solidfire.com/solution/overview/?video=play>
> *(tm)*