You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Prabhu Joseph (JIRA)" <ji...@apache.org> on 2019/02/05 08:44:00 UTC
[jira] [Comment Edited] (YARN-9253) Add UT to verify Placement
Constraint in Distributed Shell
[ https://issues.apache.org/jira/browse/YARN-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760579#comment-16760579 ]
Prabhu Joseph edited comment on YARN-9253 at 2/5/19 8:43 AM:
-------------------------------------------------------------
[~cheersyang] TestDistributedShell all test cases uses 1 NodeManager. Faced MiniYARNCluster conflicts when adding the placement constraint test case with 2 nodemanagers into TestDistributedShell. To avoid conflict, thought of having a separate class but then found TestDistributedShellWithNodeLabels has used two NodeManagers and so reused it with renaming the file into TestDSWithMultipleNodeManager. All DistributedShell test cases like NodeLabels, PlacementConstraint, AllocationTag NameSpace can be well tested with multiple nodemanagers can use this class TestDSWithMultipleNodeManager.
git diff shows all existing lines of code from TestDistributedShellWithNodeLabels as newly added (made difficult to review) but have added only testDistributedShellWithPlacementConstraint and renamed file into TestDSWithMultipleNodeManager.
was (Author: prabhu joseph):
[~cheersyang] TestDistributedShell all test cases uses 1 NodeManager. Faced MiniYARNCluster conflicts when adding the placement constraint test case with 2 nodemanagers into TestDistributedShell. To avoid conflict, thought of having a separate class but then found TestDistributedShellWithNodeLabels has used two NodeManagers and so reused it with renaming the file into TestDSWithMultipleNodeManager. All DistributedShell test cases like NodeLabels, PlacementConstraint, AllocationTag NameSpace can be well tested with multiple nodemanagers can use this class TestDSWithMultipleNodeManager.
> Add UT to verify Placement Constraint in Distributed Shell
> ----------------------------------------------------------
>
> Key: YARN-9253
> URL: https://issues.apache.org/jira/browse/YARN-9253
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.1.1
> Reporter: Prabhu Joseph
> Assignee: Prabhu Joseph
> Priority: Major
> Attachments: YARN-9253-001.patch, YARN-9253-002.patch, YARN-9253-003.patch, YARN-9253-004.patch, YARN-9253-005.patch
>
>
> Add UT to verify Placement Constraint in Distributed Shell added as part of YARN-7745
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org