You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/12 15:15:19 UTC

[GitHub] [dolphinscheduler] v-wx-v opened a new pull request, #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

v-wx-v opened a new pull request, #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163

   [BUG][install.sh] fix the install Error "Command not found rmr"  & support ZooKeeper (3.4.6+)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhuangchong commented on pull request #13163: [improvement][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#issuecomment-1377075076

   > > CI exception is zk related dependency version detection exception. If zk-3.8 is used as the default option, there will be no problem with this dependency check.
   > 
   > Error: org.owasp.dependencycheck.data.nvdcve.DatabaseException: Error updating '[CVE-2020-36569](https://github.com/advisories/GHSA-hrm3-3xm6-x33h)' org.owasp.dependencycheck.data.update.exception.UpdateException: org.owasp.dependencycheck.data.nvdcve.DatabaseException: Error updating '[CVE-2020-36569](https://github.com/advisories/GHSA-hrm3-3xm6-x33h)'
   > 
   > [CVE-2020-36569](https://github.com/advisories/GHSA-hrm3-3xm6-x33h) Authentication is globally bypassed in githubcom/nanobox-io/golang-nanoauth between v000-20160722212129-ac0cc4484ad4 and v000-20200131131040-063a3fb69896 if ListenAndServe is called with an empty token authentication complexity vector not available not available not available confidentiality integrity availability not available not availabl
   > 
   > No correlation seen
   
   I'm talking about this part 'https://github.com/apache/dolphinscheduler/actions/runs/3867927850/jobs/6597354529#step:7:1027', 
   
   OWASP detection is not mandatory to succeed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1046591709


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   1. The doc said that DS supports ZooKeeper (3.4.6+). If DS does not support ZooKeeper 3.4 , please update the doc and shell.
   2. Currently, ZooKeeper 3.4 has a large number of users. Only one can choose between security and compatibility
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1046591709


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   1. The doc said that DS supports ZooKeeper (3.4.6+). If DS does not support ZooKeeper 3.4 , please update the doc and shell.
   2. Currently, ZooKeeper 3.4 has a large number of users. Only one can choose between security and compatibility
   3. The ZooKeeper 3.8.0  cannot avoid CVE (Vulnerabilities from dependencies) also. Please see https://mvnrepository.com/artifact/org.apache.zookeeper/zookeeper/3.8.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1046621706


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   In most cases, we only upgrade the dependencies instead of downgrading them. If you think it is necessary to support ZK version 3.4, you could submit a PR to support both 3.4 and 3.8 instead of downgrading it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #13163: [improvement][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#issuecomment-1379909805

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13163)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13163&metric=coverage&view=list) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13163&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13163&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1046591709


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   1. The doc said that DS supports ZooKeeper (3.4.6+). If DS does not support ZooKeeper 3.4 , please update the doc and shell.
   2. Currently, ZooKeeper 3.4 has a large number of users. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1059006711


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   @SbloodyS  @EricGao888  
   1. Usually, upgrading dependencies  versions is easy. But, I did not see the need for this upgrade. 
   2. When using ZK  3.4.X, this upgrade caused major problems with not installing and not running. 
   3. ZK is part of the infrastructure.Upgrading ZK should be well discussed and should be done carefully
   4. So I don't think it should be the "priority:low" label.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1046591709


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   1. The doc said that DS support ZooKeeper (3.4.6+). If DS does not support ZooKeeper 3.4 , please update the doc.
   2. Currently, ZooKeeper 3.4 has a large number of users. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1046591709


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   1. The doc said that DS support ZooKeeper (3.4.6+). If DS does not support ZooKeeper 3.4 , please update the doc and shell.
   2. Currently, ZooKeeper 3.4 has a large number of users. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1055171672


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   @SbloodyS @EricGao888 @danielfree @ke4qqq Any other questions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on pull request #13163: [improvement][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#issuecomment-1377051392

   > CI exception is zk related dependency version detection exception. If zk-3.8 is used as the default option, there will be no problem with this dependency check.
   
   Error:  org.owasp.dependencycheck.data.nvdcve.DatabaseException: Error updating 'CVE-2020-36569'
   org.owasp.dependencycheck.data.update.exception.UpdateException: org.owasp.dependencycheck.data.nvdcve.DatabaseException: Error updating 'CVE-2020-36569'
   
   CVE-2020-36569 Authentication is globally bypassed in githubcom/nanobox-io/golang-nanoauth between v000-20160722212129-ac0cc4484ad4 and v000-20200131131040-063a3fb69896 if ListenAndServe is called with an empty token authentication complexity vector not available not available not available confidentiality integrity availability not available not availabl
   
   No correlation seen
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1055174941


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   > In most cases, we only upgrade the dependencies instead of downgrading them. If you think it is necessary to support ZK version 3.4, you could submit a PR to support both 3.4 and 3.8 instead of downgrading it.
   
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1046680159


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
    This PR support both 3.4 and 3.8



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhuangchong commented on pull request #13163: [improvement][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#issuecomment-1376967855

   CI exception is zk related dependency version detection exception. If zk-3.8 is used as the default option, there will be no problem with this dependency check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #13163: [improvement][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#issuecomment-1379905144

   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#13163](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee500a) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/1edee6224c2bc4bf5a1be175e440015a873aa576?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1edee62) will **decrease** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev   #13163      +/-   ##
   ============================================
   - Coverage     39.47%   39.43%   -0.05%     
   + Complexity     4313     4309       -4     
   ============================================
     Files          1083     1083              
     Lines         40756    40710      -46     
     Branches       4673     4655      -18     
   ============================================
   - Hits          16088    16052      -36     
   + Misses        22880    22873       -7     
   + Partials       1788     1785       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...r/plugin/registry/zookeeper/ZookeeperRegistry.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZWdpc3RyeS9kb2xwaGluc2NoZWR1bGVyLXJlZ2lzdHJ5LXBsdWdpbnMvZG9scGhpbnNjaGVkdWxlci1yZWdpc3RyeS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3JlZ2lzdHJ5L3pvb2tlZXBlci9ab29rZWVwZXJSZWdpc3RyeS5qYXZh) | `43.54% <0.00%> (-6.46%)` | :arrow_down: |
   | [...eduler/api/dto/schedule/ScheduleCreateRequest.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9zY2hlZHVsZS9TY2hlZHVsZUNyZWF0ZVJlcXVlc3QuamF2YQ==) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
   | [...org/apache/dolphinscheduler/remote/utils/Host.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0hvc3QuamF2YQ==) | `42.55% <0.00%> (-2.13%)` | :arrow_down: |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `51.38% <0.00%> (-1.39%)` | :arrow_down: |
   | [...e/dolphinscheduler/service/queue/TaskPriority.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvcXVldWUvVGFza1ByaW9yaXR5LmphdmE=) | `51.31% <0.00%> (-1.25%)` | :arrow_down: |
   | [...cheduler/plugin/alert/dingtalk/DingTalkSender.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9kb2xwaGluc2NoZWR1bGVyLWFsZXJ0LXBsdWdpbnMvZG9scGhpbnNjaGVkdWxlci1hbGVydC1kaW5ndGFsay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vYWxlcnQvZGluZ3RhbGsvRGluZ1RhbGtTZW5kZXIuamF2YQ==) | `34.13% <0.00%> (-0.78%)` | :arrow_down: |
   | [...pache/dolphinscheduler/common/utils/DateUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0RhdGVVdGlscy5qYXZh) | `68.13% <0.00%> (-0.73%)` | :arrow_down: |
   | [...inscheduler/plugin/registry/etcd/EtcdRegistry.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZWdpc3RyeS9kb2xwaGluc2NoZWR1bGVyLXJlZ2lzdHJ5LXBsdWdpbnMvZG9scGhpbnNjaGVkdWxlci1yZWdpc3RyeS1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9yZWdpc3RyeS9ldGNkL0V0Y2RSZWdpc3RyeS5qYXZh) | `50.34% <0.00%> (-0.69%)` | :arrow_down: |
   | [...he/dolphinscheduler/plugin/task/java/JavaTask.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stamF2YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vdGFzay9qYXZhL0phdmFUYXNrLmphdmE=) | `58.50% <0.00%> (-0.69%)` | :arrow_down: |
   | [...duler/plugin/storage/hdfs/HdfsStorageOperator.java](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zdG9yYWdlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXN0b3JhZ2UtaGRmcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vc3RvcmFnZS9oZGZzL0hkZnNTdG9yYWdlT3BlcmF0b3IuamF2YQ==) | `11.76% <0.00%> (-0.61%)` | :arrow_down: |
   | ... and [25 more](https://codecov.io/gh/apache/dolphinscheduler/pull/13163?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1046591709


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   1. The doc said that DS supports ZooKeeper (3.4.6+). If DS does not support ZooKeeper 3.4 , please update the doc and shell.
   2. Currently, ZooKeeper 3.4 has a large number of users. Only one can choose between security and compatibility



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] v-wx-v commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
v-wx-v commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1046591709


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   1. The doc said that DS supports ZooKeeper (3.4.6+). If DS does not support ZooKeeper 3.4 , please update the doc and shell.
   2. Currently, ZooKeeper 3.4 has a large number of users. Only one can choose between security and compatibility
   3. The ZooKeeper 3.8.0  cannot avoid CVE. Please see https://mvnrepository.com/artifact/org.apache.zookeeper/zookeeper/3.8.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #13163: [BUG][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#discussion_r1046582779


##########
dolphinscheduler-bom/pom.xml:
##########
@@ -35,8 +35,8 @@
         <mybatis-plus.version>3.5.2</mybatis-plus.version>
         <quartz.version>2.3.2</quartz.version>
         <druid.version>1.2.4</druid.version>
-        <zookeeper.version>3.8.0</zookeeper.version>
-        <curator.version>5.3.0</curator.version>
+        <curator.version>4.3.0</curator.version>
+        <zookeeper.version>3.4.14</zookeeper.version>

Review Comment:
   I dont't think it's a good idea. We upgrade to this version mainly to avoid CVE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #13163: [improvement][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163#issuecomment-1379914039

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13163)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13163&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13163&metric=coverage&view=list) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13163&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13163&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] davidzollo merged pull request #13163: [improvement][install.sh] fix the install Error "Command not found rmr" & su…

Posted by GitBox <gi...@apache.org>.
davidzollo merged PR #13163:
URL: https://github.com/apache/dolphinscheduler/pull/13163


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org