[GitHub] [rocketmq-eventbridge] 2011shenlin commented on a diff in pull request #36: add access log

[GitBox <gi...@apache.org>]

2011shenlin commented on code in PR #36:
URL: https://github.com/apache/rocketmq-eventbridge/pull/36#discussion_r996552994


##########
adapter/api/src/main/java/org/apache/rocketmq/eventbridge/adapter/api/handler/WebLogAspect.java:
##########
@@ -18,35 +18,45 @@
 package org.apache.rocketmq.eventbridge.adapter.api.handler;
 
 import com.google.gson.Gson;
-import lombok.extern.slf4j.Slf4j;
 import org.aspectj.lang.ProceedingJoinPoint;
 import org.aspectj.lang.annotation.Around;
 import org.aspectj.lang.annotation.Aspect;
 import org.aspectj.lang.annotation.Pointcut;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.stereotype.Component;
+import reactor.core.publisher.Mono;
+
+import java.util.Objects;
 
-@Slf4j
 @Aspect
 @Component
 public class WebLogAspect {
 
+    private static final Logger log = LoggerFactory.getLogger("accessLog");
+
     @Pointcut("@annotation(org.apache.rocketmq.eventbridge.adapter.api.annotations.WebLog)")
     public void webLog() {
 
     }
 
     @Around("webLog()")

Review Comment:
   Annotations are not recommended for access logs, and unmarked requests should also have access logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org