You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/10 10:03:06 UTC

[GitHub] [incubator-nuttx-apps] davids5 commented on a diff in pull request #1193: serialblaster bugfix

davids5 commented on code in PR #1193:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1193#discussion_r894365990


##########
examples/serialblaster/serialblaster_main.c:
##########
@@ -59,7 +59,7 @@ int main(int argc, FAR char *argv[])
   int ret;
   int fd;
   FAR char *devpath;
-  int size = 0;
+  int size = sizeof(s)-1;

Review Comment:
   ```suggestion
     const int slength  = sizeof(s)-1;
     int size = slength;
   ```
   and replace it throughout the code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org