You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/04/11 15:07:33 UTC
[GitHub] [incubator-inlong] ciscozhou opened a new pull request, #3626: [INLONG-3167][InLong] Remove the unused git hook and adjust the PR template
ciscozhou opened a new pull request, #3626:
URL: https://github.com/apache/incubator-inlong/pull/3626
### Title Name: [INLONG-3167][InLong] Remove the unused git hook and adjust the PR template
Fixes #3167
### Motivation
1. Remove the unused git hook.
2. Adjust the PR template.
### Verifying this change
- [X] This change is a trivial rework / code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #3626: [INLONG-3167][InLong] Remove the unused git hook and adjust the PR template
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #3626:
URL: https://github.com/apache/incubator-inlong/pull/3626#discussion_r847869431
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -7,35 +6,30 @@ Fixes #<xyz>
### Motivation
-*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
+*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
-- [ ] Make sure that the change passes the CI checks.
-
*(Please pick either of the following options)*
-This change is a trivial rework / code cleanup without any test coverage.
-
-*(or)*
-
-This change is already covered by existing tests, such as *(please describe tests)*.
+- [ ] This change is a trivial rework/code cleanup without any test coverage.
-*(or)*
+- [ ] This change is already covered by existing tests, such as:
+ *(please describe tests)*
-This change added tests and can be verified as follows:
+- [ ] This change added tests and can be verified as follows:
-*(example:)*
+ *(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- - Does this pull request introduce a new feature? (yes / no)
+ - Does this pull request introduces a new feature? (yes / no)
Review Comment:
```suggestion
- Does this pull request introduce a new feature? (yes / no)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang merged pull request #3626: [INLONG-3167][InLong] Remove the unused git hook and adjust the PR template
Posted by GitBox <gi...@apache.org>.
gosonzhang merged PR #3626:
URL: https://github.com/apache/incubator-inlong/pull/3626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org