You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/06 16:31:50 UTC

[GitHub] [calcite] vlsi commented on a change in pull request #1638: [CALCITE-3540] FoodmartTest produces many warnings due to incorrect use of CalciteAssert.pooled()

vlsi commented on a change in pull request #1638: [CALCITE-3540] FoodmartTest produces many warnings due to incorrect use of CalciteAssert.pooled()
URL: https://github.com/apache/calcite/pull/1638#discussion_r354919899
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/FoodmartTest.java
 ##########
 @@ -38,6 +38,13 @@
 @Tag("slow")
 public class FoodmartTest {
 
+  private static final CalciteAssert.AssertThat ASSERT_FOODMART = CalciteAssert.that()
 
 Review comment:
   I'm not sure what's the difference between `private static final` vs `@BeforeAll`, but I guess this is ok.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services