You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/11/28 17:23:16 UTC
[GitHub] [activemq] Dm-Chebotarskyi opened a new pull request, #943: Added additional logging on BrokerService startup
Dm-Chebotarskyi opened a new pull request, #943:
URL: https://github.com/apache/activemq/pull/943
### Description
Adding some logging on startup of BrokerService. We had an occurrence where broker was stuck on startup for 33 minutes with the following logs:
```
2022-10-24 12:33:01,972 | INFO | Using Persistence Adapter: KahaDBPersistenceAdapter[/data/kahadb] | org.apache.activemq.broker.BrokerService | main
// ~33 mins between these 2 logs
2022-10-24 13:06:23,710 | INFO | KahaDB is version 6 | org.apache.activemq.store.kahadb.MessageDatabase | main
```
Normally, broker loading time between these 2 log entries is several seconds.
This logs supposed to give more insights during the next occurrence of the issue on where broker spent this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] jbonofre closed pull request #943: Added additional logging on BrokerService startup
Posted by GitBox <gi...@apache.org>.
jbonofre closed pull request #943: Added additional logging on BrokerService startup
URL: https://github.com/apache/activemq/pull/943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] jbonofre commented on pull request #943: Added additional logging on BrokerService startup
Posted by GitBox <gi...@apache.org>.
jbonofre commented on PR #943:
URL: https://github.com/apache/activemq/pull/943#issuecomment-1330546134
I think it's worth to add it at startup. I'm more concerned by log while running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on pull request #943: Added additional logging on BrokerService startup
Posted by GitBox <gi...@apache.org>.
mattrpav commented on PR #943:
URL: https://github.com/apache/activemq/pull/943#issuecomment-1330766512
For reference below is the default startup output as of 5.17.2
```
INFO | Using Persistence Adapter: MultiKahaDBPersistenceAdapter[/Users/mattrpav/Applications/activemq/apache-activemq-5.17.2/data/kahadb][KahaDBPersistenceAdapter[/Users/mattrpav/Applications/activemq/apache-activemq-5.17.2/data/dlq-kahadb/queue#3a#2f#2fDLQ.#3e], KahaDBPersistenceAdapter[/Users/mattrpav/Applications/activemq/apache-activemq-5.17.2/data/queues-topics/#210]]
INFO | PListStore:[/Users/mattrpav/Applications/activemq/apache-activemq-5.17.2/data/localhost/tmp_storage] started
INFO | Apache ActiveMQ 5.17.2 (localhost, ID:mattbookpro-54431-1669733306480-0:1) is starting
INFO | pending local transactions: []
INFO | Listening for connections at: tcp://mattbookpro:61616?maximumConnections=1000&wireFormat.maxFrameSize=104857600
INFO | Connector openwire started
INFO | Listening for connections at: amqp://mattbookpro:5672?maximumConnections=1000&wireFormat.maxFrameSize=104857600
INFO | Connector amqp started
INFO | Listening for connections at: stomp://mattbookpro:61613?maximumConnections=1000&wireFormat.maxFrameSize=104857600
INFO | Connector stomp started
INFO | Listening for connections at: mqtt://mattbookpro:1883?maximumConnections=1000&wireFormat.maxFrameSize=104857600
INFO | Connector mqtt started
INFO | Starting Jetty server
INFO | Creating Jetty connector
WARN | ServletContext@o.e.j.s.ServletContextHandler@47406941{/,null,STARTING} has uncovered http methods for path: /
INFO | Listening for connections at ws://mattbookpro:61614?maximumConnections=1000&wireFormat.maxFrameSize=104857600
INFO | Connector ws started
INFO | Apache ActiveMQ 5.17.2 (localhost, ID:mattbookpro-54431-1669733306480-0:1) started
INFO | For help or more information please see: http://activemq.apache.org
INFO | ActiveMQ WebConsole available at http://127.0.0.1:8161/
INFO | ActiveMQ Jolokia REST API available at http://127.0.0.1:8161/api/jolokia/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] jbonofre commented on a diff in pull request #943: Added additional logging on BrokerService startup
Posted by GitBox <gi...@apache.org>.
jbonofre commented on code in PR #943:
URL: https://github.com/apache/activemq/pull/943#discussion_r1034839848
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -668,10 +668,13 @@ private void doStartPersistenceAdapter() throws Exception {
persistenceAdapterToStart.setBrokerName(getBrokerName());
LOG.info("Using Persistence Adapter: {}", persistenceAdapterToStart);
if (deleteAllMessagesOnStartup) {
+ LOG.info("Deleting all messages on startup because deleteAllMessagesOnStartup configuration has been provided");
deleteAllMessages();
}
+ LOG.info("Starting Persistence Adapter: {}", persistenceAdapterToStart);
persistenceAdapterToStart.start();
+ LOG.info("Starting Temp Data Store");
Review Comment:
Agree, but I think it's already useful to know what is started and when (especially when the log message are consumed by metrics).
I propose to improve this for next release, maybe we can add a Jira about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on a diff in pull request #943: Added additional logging on BrokerService startup
Posted by GitBox <gi...@apache.org>.
mattrpav commented on code in PR #943:
URL: https://github.com/apache/activemq/pull/943#discussion_r1034824113
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -668,10 +668,13 @@ private void doStartPersistenceAdapter() throws Exception {
persistenceAdapterToStart.setBrokerName(getBrokerName());
LOG.info("Using Persistence Adapter: {}", persistenceAdapterToStart);
if (deleteAllMessagesOnStartup) {
+ LOG.info("Deleting all messages on startup because deleteAllMessagesOnStartup configuration has been provided");
deleteAllMessages();
}
+ LOG.info("Starting Persistence Adapter: {}", persistenceAdapterToStart);
persistenceAdapterToStart.start();
+ LOG.info("Starting Temp Data Store");
Review Comment:
Same here.. would be super useful to know how long it took to start and how many messages vs 'just.. i'm starting'
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -685,6 +688,7 @@ private void doStartPersistenceAdapter() throws Exception {
}
}
+ LOG.info("Starting Job Scheduler Store");
Review Comment:
This line shouldn't be logged, unless there is a job store configured, right? Same.. as the others.. I think a startup time plus # of messages is more useful.
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -668,10 +668,13 @@ private void doStartPersistenceAdapter() throws Exception {
persistenceAdapterToStart.setBrokerName(getBrokerName());
LOG.info("Using Persistence Adapter: {}", persistenceAdapterToStart);
if (deleteAllMessagesOnStartup) {
+ LOG.info("Deleting all messages on startup because deleteAllMessagesOnStartup configuration has been provided");
deleteAllMessages();
}
+ LOG.info("Starting Persistence Adapter: {}", persistenceAdapterToStart);
Review Comment:
This line seems redundant to L669. How about moving this to after the persistence completes and adding some statistics -- like how long it took or how many messages available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] asfgit closed pull request #943: Added additional logging on BrokerService startup
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #943: Added additional logging on BrokerService startup
URL: https://github.com/apache/activemq/pull/943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on pull request #943: Added additional logging on BrokerService startup
Posted by GitBox <gi...@apache.org>.
mattrpav commented on PR #943:
URL: https://github.com/apache/activemq/pull/943#issuecomment-1330542311
Does this add all the log output to every startup? We went through a round of reducing startup log output a while back, not sure we want to add 7 lines to every startup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org