[jira] [Work logged] (HADOOP-17921) DistCp derives if XAttr is supported wrongly

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-17921?focusedWorklogId=652968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652968 ]

ASF GitHub Bot logged work on HADOOP-17921:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Sep/21 13:47
            Start Date: 20/Sep/21 13:47
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha opened a new pull request #3463:
URL: https://github.com/apache/hadoop/pull/3463


   
   ### Description of PR
   The exception handling in distcp code during the check seems improper. In a FileSystem implementation which doesn't override getXAttrs(), it would throw UnsupportedOperationException(). However, in distCp while handling the code, it tries to catch Exception class. That would result in normal IOException also treated as if the feature is not supported. This will lead to wrong behavior.
   
   ### How was this patch tested?
   :eyes:
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 652968)
    Remaining Estimate: 0h
            Time Spent: 10m

> DistCp derives if XAttr is supported wrongly
> --------------------------------------------
>
>                 Key: HADOOP-17921
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17921
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Pravin Sinha
>            Assignee: Pravin Sinha
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {color:#0033b3}public static void {color}{color:#00627a}checkFileSystemXAttrSupport{color}({color:#000000}FileSystem {color}fs)
>  {color:#0033b3}throws {color}{color:#000000}XAttrsNotSupportedException {color}{
>  {color:#0033b3}try {color}{
>  fs.getXAttrs({color:#0033b3}new {color}Path({color:#000000}Path{color}.{color:#871094}SEPARATOR{color}));
>  } {color:#0033b3}catch {color}({color:#000000}Exception {color}e) {
>  {color:#0033b3}throw new {color}XAttrsNotSupportedException({color:#067d17}"XAttrs not supported for file system: "
> {color} + fs.getUri());
>  }
> }
> IOExecption will also be treated as if Xattr is not supported, which would be wrong.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org