You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/03/28 23:29:28 UTC

[kudu-CR] KUDU-379: fix LESS_EQUAL predicates on bool, float and double columns

Hello Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2647

to look at the new patch set (#2).

Change subject: KUDU-379: fix LESS_EQUAL predicates on bool, float and double columns
......................................................................

KUDU-379: fix LESS_EQUAL predicates on bool, float and double columns

This commit adds missing implementation of IncrementCell for bool, float and
double columns, which fixes a TS crash when scanning with an inclusive
upper-bound predicate on these column types. A follow up commit will add tests
for predicates on all column types.

Change-Id: I46cc354b70effba51037f640358f4df5d1fc6657
---
M src/kudu/common/key_util.cc
1 file changed, 34 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/2647/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46cc354b70effba51037f640358f4df5d1fc6657
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>