You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/07/06 07:35:23 UTC
[GitHub] [incubator-celeborn] pan3793 opened a new pull request, #1684: [CELEBORN-774] Pullout celeborn.rpc.dispatcher.threads to CelebornConf
pan3793 opened a new pull request, #1684:
URL: https://github.com/apache/incubator-celeborn/pull/1684
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Pullout hardcoded `celeborn.rpc.dispatcher.numThreads` to `CelebornConf` and rename it to `celeborn.rpc.dispatcher.threads` to align with existing configuration style
### Why are the changes needed?
Pullout inline configuration to `CelebornConf`, and expose it in configuration docs
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1684: [CELEBORN-774] Pullout celeborn.rpc.dispatcher.threads to CelebornConf
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1684:
URL: https://github.com/apache/incubator-celeborn/pull/1684#issuecomment-1623143717
BTW, I notice the current `Dispatcher` code is port for Spark 2.x, SPARK-29398 changed it a lot in Spark 3.0, we may want to update the code in the future if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1684: [CELEBORN-774] Pullout celeborn.rpc.dispatcher.threads to CelebornConf
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1684:
URL: https://github.com/apache/incubator-celeborn/pull/1684#issuecomment-1623142079
cc @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1684: [CELEBORN-774] Pullout celeborn.rpc.dispatcher.threads to CelebornConf
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1684: [CELEBORN-774] Pullout celeborn.rpc.dispatcher.threads to CelebornConf
URL: https://github.com/apache/incubator-celeborn/pull/1684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1684: [CELEBORN-774] Pullout celeborn.rpc.dispatcher.threads to CelebornConf
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1684:
URL: https://github.com/apache/incubator-celeborn/pull/1684#issuecomment-1623208423
Thanks, merged to main/0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1684: [CELEBORN-774] Pullout celeborn.rpc.dispatcher.threads to CelebornConf
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1684:
URL: https://github.com/apache/incubator-celeborn/pull/1684#issuecomment-1623156165
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1684](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (79a3e4a) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/09881f5cff4c0e6843afd942bb3932bb1758232c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (09881f5) will **decrease** coverage by `0.09%`.
> The diff coverage is `66.67%`.
```diff
@@ Coverage Diff @@
## main #1684 +/- ##
==========================================
- Coverage 46.27% 46.17% -0.09%
==========================================
Files 161 161
Lines 9990 9996 +6
Branches 924 924
==========================================
- Hits 4622 4615 -7
- Misses 5061 5072 +11
- Partials 307 309 +2
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../apache/celeborn/common/rpc/netty/Dispatcher.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3JwYy9uZXR0eS9EaXNwYXRjaGVyLnNjYWxh) | `31.87% <20.00%> (+0.35%)` | :arrow_up: |
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.19% <100.00%> (+0.04%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1684/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org