You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/10/12 22:34:28 UTC

[GitHub] [pinot] walterddr commented on pull request #9580: [cleanup] moving test sql to a yaml file for better readability

walterddr commented on PR #9580:
URL: https://github.com/apache/pinot/pull/9580#issuecomment-1276801335

   > 😍 yessss! can we also do that for QueryRunnerTest and make this a generic thing we can use in lots of tests 🙏
   
   good idea. although there's more to improve in QueryRunnerTest for example
   - better data randomness, currently they are hard-coded
   - better data type coverage, current only 2 numeric, 2 string and 1 timestamp
   - better table schema, currently all are the same.
   let's create an issue to track this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org