You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2014/12/12 15:21:26 UTC
Review Request 28995: LENS-114 : Fact filter pushdown and fact key
projection in inner fact query
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28995/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Repository: lens
Description
-------
Currently only fact keys those are part of from clause were considered while building fact subquery. It should also check select and where clause for any fact key and add in the inner subquery. Along with this fact filters part of where or join clauses should pushed down to fact subquery to reduce fact result set for further joining with dimensions.
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 323f6f0
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java d35e172
Diff: https://reviews.apache.org/r/28995/diff/
Testing
-------
Tested with filters from join and where clause pushdown into fact query. Tested fact key projection in inner subquery. Added unit test for this.
Thanks,
Sushil Mohanty
Re: Review Request 28995: LENS-114 : Fact filter pushdown and fact key
projection in inner fact query
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28995/#review64917
-----------------------------------------------------------
Ship it!
I again see some trailing white space. Sushil, please set IDE to remove all trailing whitespace.
+1 for the patch
- Jaideep dhok
On Dec. 12, 2014, 2:21 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28995/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 2:21 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-114
> https://issues.apache.org/jira/browse/LENS-114
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently only fact keys those are part of from clause were considered while building fact subquery. It should also check select and where clause for any fact key and add in the inner subquery. Along with this fact filters part of where or join clauses should pushed down to fact subquery to reduce fact result set for further joining with dimensions.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 323f6f0
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java d35e172
>
> Diff: https://reviews.apache.org/r/28995/diff/
>
>
> Testing
> -------
>
> Tested with filters from join and where clause pushdown into fact query. Tested fact key projection in inner subquery. Added unit test for this.
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 28995: LENS-114 : Fact filter pushdown and fact key
projection in inner fact query
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28995/
-----------------------------------------------------------
(Updated Dec. 12, 2014, 2:21 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-114
https://issues.apache.org/jira/browse/LENS-114
Repository: lens
Description
-------
Currently only fact keys those are part of from clause were considered while building fact subquery. It should also check select and where clause for any fact key and add in the inner subquery. Along with this fact filters part of where or join clauses should pushed down to fact subquery to reduce fact result set for further joining with dimensions.
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 323f6f0
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java d35e172
Diff: https://reviews.apache.org/r/28995/diff/
Testing
-------
Tested with filters from join and where clause pushdown into fact query. Tested fact key projection in inner subquery. Added unit test for this.
Thanks,
Sushil Mohanty