You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Mike Matrigali (JIRA)" <ji...@apache.org> on 2007/05/07 06:32:15 UTC
[jira] Resolved: (DERBY-1665) Incorrect JavaDoc for Qualifier
interface
[ https://issues.apache.org/jira/browse/DERBY-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Matrigali resolved DERBY-1665.
-----------------------------------
Resolution: Fixed
Fix Version/s: 10.3.0.0
Assignee: Andrew McIntyre
> Incorrect JavaDoc for Qualifier interface
> -----------------------------------------
>
> Key: DERBY-1665
> URL: https://issues.apache.org/jira/browse/DERBY-1665
> Project: Derby
> Issue Type: Bug
> Components: Javadoc
> Reporter: Andy Coulbeck
> Assigned To: Andrew McIntyre
> Priority: Trivial
> Fix For: 10.3.0.0
>
>
> Just some small comments about the Javadoc for the org.apache.derby.iapi.store.access.Qualifier interface, that made it hard for me to understand. (see http://db.apache.org/derby/javadoc/engine/)
> 1. In examples 1a through 4 there looks to be a missing [] in the array initialization. In example 1a, instead of:
> qualifier = new Qualifier[3]; // 3 AND clauses
> I think it should be:
> qualifier = new Qualifier[3][]; // 3 AND clauses
> Similar for 2 through 4.
> 2. The formatting is messed up as the text for the examples appears as one long hyperlink in the seeAlso section.
> 3. This pseudo-code doesn't look right. I don't think there should be a test on qualifier.negateCompareResult() at the outer level?
> if (qualifier.negateCompareResult())
> {
> compare_result =
> row[(qualifier.getColumnId())].compare(
> qualifier.getOperator(),
> qualifier.getOrderable(),
> qualifier.getOrderedNulls(),
> qualifier.getUnknownRV())
> if (qualifier.negateCompareResult()) {
> compare_result = !(compare_result);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.