You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "rondagostino (via GitHub)" <gi...@apache.org> on 2023/02/03 22:40:23 UTC
[GitHub] [kafka] rondagostino opened a new pull request, #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0
rondagostino opened a new pull request, #13198:
URL: https://github.com/apache/kafka/pull/13198
https://github.com/apache/kafka/pull/11390/ will be released as part of AK 3.5 but it added the MetadataVersion `IBP_3_4_IV1`. It should have been `IBP_3_5_IV0`. This change causes no incompatibility because this feature is not yet released.
Also, `didMetadataChange` is adjusted to `false` because the KRaft metadata log records are unaffected.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe merged PR #13198:
URL: https://github.com/apache/kafka/pull/13198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on a diff in pull request #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on code in PR #13198:
URL: https://github.com/apache/kafka/pull/13198#discussion_r1097417323
##########
core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala:
##########
@@ -174,7 +174,7 @@ class FeatureCommandUnitTest {
@Test
def testMetadataVersionsToString(): Unit = {
assertEquals("3.3-IV0, 3.3-IV1, 3.3-IV2, 3.3-IV3, 3.4-IV0, 3.4-IV1",
Review Comment:
Already pointed out by @satishd, but I believe changing 3.4-IV1 to 3.5-IV0 here will make the test pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on a diff in pull request #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on code in PR #13198:
URL: https://github.com/apache/kafka/pull/13198#discussion_r1097417323
##########
core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala:
##########
@@ -174,7 +174,7 @@ class FeatureCommandUnitTest {
@Test
def testMetadataVersionsToString(): Unit = {
assertEquals("3.3-IV0, 3.3-IV1, 3.3-IV2, 3.3-IV3, 3.4-IV0, 3.4-IV1",
Review Comment:
Already pointed out by @fvaleri, but I believe changing 3.4-IV1 to 3.5-IV0 here will make the test pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on a diff in pull request #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on code in PR #13198:
URL: https://github.com/apache/kafka/pull/13198#discussion_r1097417323
##########
core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala:
##########
@@ -174,7 +174,7 @@ class FeatureCommandUnitTest {
@Test
def testMetadataVersionsToString(): Unit = {
assertEquals("3.3-IV0, 3.3-IV1, 3.3-IV2, 3.3-IV3, 3.4-IV0, 3.4-IV1",
Review Comment:
Already pointed out by @fvaleri, but I believe changing 3.4-IV1 here will make the test pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org