You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/04/27 20:18:04 UTC
[jira] [Commented] (CB-12497) location.href links are silently
disallowed
[ https://issues.apache.org/jira/browse/CB-12497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987568#comment-15987568 ]
ASF subversion and git services commented on CB-12497:
------------------------------------------------------
Commit 8755a699187c7fc2203c98fcc4fa78b89f1c513e in cordova-plugin-wkwebview-engine's branch refs/heads/1.1.x from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=8755a69 ]
CB-12497 - location.href links are silently disallowed
This closes #32
> location.href links are silently disallowed
> -------------------------------------------
>
> Key: CB-12497
> URL: https://issues.apache.org/jira/browse/CB-12497
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin WKWebViewEngine
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
>
> See: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20#issuecomment-281861506
> Ok, for location.href (say in a button tag onclick handler), it's definitely a bug when using wkwebview-engine (UIWebView is fine). For the CDVIntentAndNavigationFilter, we are passing back the navigationType, which is of type [WKNavigationType](https://developer.apple.com/reference/webkit/wknavigationtype). It looks like the enumeration is the same as [UIWebViewNavigationType](https://developer.apple.com/reference/uikit/uiwebviewnavigationtype) (which the filter uses for its logic), but not quite.
> All enum integral values are the same for the two enumerations, except for [WKNavigationTypeOther](https://developer.apple.com/reference/webkit/wknavigationtype/1401930-other) which is set to -1 explicitly, while [UIWebViewNavigationTypeOther](https://developer.apple.com/reference/uikit/uiwebviewnavigationtype/1617934-other) is 5.
> I'll file an issue to fix this by coercing the value explicitly to UIWebViewNavigationTypeOther when a WKNavigationTypeOther is encountered, before passing it off to the filter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org