[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #1361: SAMZA-2525:Fix race condition in ClientHelper#isActiveApplication

[GitBox <gi...@apache.org>]

lakshmi-manasa-g commented on a change in pull request #1361:
URL: https://github.com/apache/samza/pull/1361#discussion_r425994565



##########
File path: samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala
##########
@@ -301,8 +301,8 @@ class ClientHelper(conf: Configuration) extends Logging {
   }
 
   private def isActiveApplication(applicationReport: ApplicationReport): Boolean = {
-    (Running.equals(toAppStatus(applicationReport).get)
-    || New.equals(toAppStatus(applicationReport).get))
+    val status = toAppStatus(applicationReport).get

Review comment:
       but application report does not change.. so how would toAppStatus return different values for the same applicationReport? i thought applicationReport does NOT change within the same invocation of isActiveAppliction.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org