[GitHub] [accumulo] ctubbsii commented on a change in pull request #1334: Prefer ArrayList over LinkedList and native array

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1334: Prefer ArrayList over LinkedList and native array
URL: https://github.com/apache/accumulo/pull/1334#discussion_r323062262
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/iterators/system/LocalityGroupIterator.java
 ##########
 @@ -134,7 +129,7 @@ public int getNumLGSeeked() {
 
   public LocalityGroupIterator(LocalityGroup[] groups) {
     super(groups.length);
-    this.lgContext = new LocalityGroupContext(groups);
+    this.lgContext = new LocalityGroupContext(Arrays.asList(groups));
 
 Review comment:
   Since this system iterator is also not public API, I wonder if there's something we can do here to pass this in as a list initially, rather than as an array that we have to convert. This could also be done in subsequent work. What do you think, @belugabehr ? Is it worth going down the rabbit hole a bit further on this one, or doing in a future change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services