[jira] Reopened: (MYFACES-2944) Make those add*** methods public in WebXml

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe reopened MYFACES-2944:
-------------------------------------


The code is good, but I don't agree that move SpiUtils to shared and create a spi interface there should be the final solution.

Have spi interfaces everywhere in myfaces code makes things harder to understand and just put all existing methods on WebXml without think which one should be exposed or not is not a good strategy. LifecycleProvider is an exception because that code comes from jsf 1.x. I think the patch committed here should be reverted, so we can fix it properly.

Note that it is possible we need some changes to fix MYFACES-2952 on WebXml.

> Make those add*** methods public in WebXml
> ------------------------------------------
>
>                 Key: MYFACES-2944
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2944
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.0.2
>            Reporter: Ivan
>            Assignee: Jakob Korherr
>             Fix For: 2.0.3-SNAPSHOT
>
>         Attachments: MYFACES-2944-core.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml, so that myfaces does not need to parse the web.xml file again, But those add*** method are package scope. 
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.