You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/24 10:44:32 UTC
[GitHub] [skywalking] ZhuoSiChen opened a new pull request #4116: keep the
properties in SnifferConfigInitializer
ZhuoSiChen opened a new pull request #4116: keep the properties in SnifferConfigInitializer
URL: https://github.com/apache/skywalking/pull/4116
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [x] Improve performance
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
When I develop my plugin I find skywalking no way to get my properties
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4116:
keep the properties in SnifferConfigInitializer
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4116: keep the properties in SnifferConfigInitializer
URL: https://github.com/apache/skywalking/pull/4116#discussion_r361137430
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
##########
@@ -40,7 +40,7 @@
private static String DEFAULT_CONFIG_FILE_NAME = "/config/agent.config";
private static String ENV_KEY_PREFIX = "skywalking.";
private static boolean IS_INIT_COMPLETED = false;
-
+ private static Properties properties;
Review comment:
Why change this? Who will use this properties? If not, this uses memory and gc load.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] ZhuoSiChen closed pull request #4116: keep the
properties in SnifferConfigInitializer
Posted by GitBox <gi...@apache.org>.
ZhuoSiChen closed pull request #4116: keep the properties in SnifferConfigInitializer
URL: https://github.com/apache/skywalking/pull/4116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services