You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/03 21:00:26 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2305: Add Target Feature Recommendations to Arrow Crate Docs

tustvold commented on code in PR #2305:
URL: https://github.com/apache/arrow-rs/pull/2305#discussion_r937133988


##########
arrow/src/lib.rs:
##########
@@ -18,6 +18,42 @@
 //! A complete, safe, native Rust implementation of [Apache Arrow](https://arrow.apache.org), a cross-language
 //! development platform for in-memory data.
 //!
+//! # Performance Tips
+//!
+//! Arrow aims to be as fast as possible out of the box, whilst not compromising on safety. However,
+//! it relies heavily on LLVM auto-vectorisation to achieve this. Unfortunately the LLVM defaults,
+//! particularly for x86_64, favour portability over performance, and LLVM will consequently avoid
+//! using more recent instructions that would result in errors on older CPUs.
+//!
+//! To address this it is recommended that you specify the override the LLVM defaults either

Review Comment:
   Oops wording error here, will fix 😅



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org