You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Benedict (JIRA)" <ji...@apache.org> on 2015/09/16 17:19:46 UTC

[jira] [Created] (CASSANDRA-10355) Flatten DataInputPlus type hierarchy

Benedict created CASSANDRA-10355:
------------------------------------

             Summary: Flatten DataInputPlus type hierarchy
                 Key: CASSANDRA-10355
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10355
             Project: Cassandra
          Issue Type: Improvement
          Components: Core
            Reporter: Benedict
            Assignee: Benedict
             Fix For: 3.0.0 rc1


Almost every instance extends {{RebufferingInputStream}} now, however there are two last implementations hanging around that we can probably do without. If we do so, the majority of method calls to any {{DataInputPlus}} (i.e., the majority of method calls full stop) can be inlined by hotspot. Thus giving us behaviour pretty similar to passing around raw {{ByteBuffer}} objects.

It's worth a shot, anyway. 

If it works remotely well, we should consider splitting readUnsignedVInt into its first byte read (which we would aim to inline) and its proceeding larger read (which we would perhaps ask not to be).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)