You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/06/02 23:29:27 UTC
Re: Review Request 59350: SENTRY-1743: Two SentryStore instances are
one too many
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59350/
-----------------------------------------------------------
(Updated June 2, 2017, 11:29 p.m.)
Review request for sentry, Brian Towles, Hao Hao, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
Changes
-------
Renamed static constructor to getInstance()
Summary (updated)
-----------------
SENTRY-1743: Two SentryStore instances are one too many
Bugs: SENTRY-1743
https://issues.apache.org/jira/browse/SENTRY-1743
Repository: sentry
Description
-------
SENTRY-1743: Two SentrySTore instances are one too many
Diffs (updated)
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java 3be6a0bf38d03f81df4aae3a878d1e6ecae52be7
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 2ca70e9885145ebee9765a1122eb23d7b1c404fc
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryAdminServlet.java 8a8bbd35c1e327fb8b613311daaafef46561b2bb
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java e9d9eec3526f2894199e81a253709dc3ed380b5b
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 3327e687f85aa0a5d40fcf299e3967d555a68d17
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java d1a88b0a91a785f68231eaa78e5b1ad8c3071150
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java 103dbb609357d75313abff2228f2f4e15bce1ecf
sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/AbstractSqoopSentryTestBase.java 67de5acb36797b23261e5023c308222ad3344ea7
Diff: https://reviews.apache.org/r/59350/diff/2/
Changes: https://reviews.apache.org/r/59350/diff/1-2/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 59350: SENTRY-1743: Two SentryStore instances are
one too many
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59350/#review176861
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 2, 2017, 11:29 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59350/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 11:29 p.m.)
>
>
> Review request for sentry, Brian Towles, Hao Hao, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1743
> https://issues.apache.org/jira/browse/SENTRY-1743
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1743: Two SentrySTore instances are one too many
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java 3be6a0bf38d03f81df4aae3a878d1e6ecae52be7
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 2ca70e9885145ebee9765a1122eb23d7b1c404fc
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryAdminServlet.java 8a8bbd35c1e327fb8b613311daaafef46561b2bb
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java e9d9eec3526f2894199e81a253709dc3ed380b5b
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 3327e687f85aa0a5d40fcf299e3967d555a68d17
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java d1a88b0a91a785f68231eaa78e5b1ad8c3071150
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java 103dbb609357d75313abff2228f2f4e15bce1ecf
> sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/AbstractSqoopSentryTestBase.java 67de5acb36797b23261e5023c308222ad3344ea7
>
>
> Diff: https://reviews.apache.org/r/59350/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 59350: SENTRY-1743: Two SentryStore instances are
one too many
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59350/#review176918
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On June 2, 2017, 11:29 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59350/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 11:29 p.m.)
>
>
> Review request for sentry, Brian Towles, Hao Hao, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1743
> https://issues.apache.org/jira/browse/SENTRY-1743
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1743: Two SentrySTore instances are one too many
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java 3be6a0bf38d03f81df4aae3a878d1e6ecae52be7
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 2ca70e9885145ebee9765a1122eb23d7b1c404fc
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryAdminServlet.java 8a8bbd35c1e327fb8b613311daaafef46561b2bb
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java e9d9eec3526f2894199e81a253709dc3ed380b5b
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 3327e687f85aa0a5d40fcf299e3967d555a68d17
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java d1a88b0a91a785f68231eaa78e5b1ad8c3071150
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java 103dbb609357d75313abff2228f2f4e15bce1ecf
> sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/AbstractSqoopSentryTestBase.java 67de5acb36797b23261e5023c308222ad3344ea7
>
>
> Diff: https://reviews.apache.org/r/59350/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>