You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by taojoe <gi...@git.apache.org> on 2014/10/07 02:27:49 UTC

[GitHub] storm pull request: delete 'some?', change 'zip-contains-dir?'. ma...

GitHub user taojoe opened a pull request:

    https://github.com/apache/storm/pull/284

    delete 'some?', change 'zip-contains-dir?'. make storm-core/src/clj/back...

    ...type/storm/util.clj compatible with clojure 1.6. in fact 'zip-contains-dir?' use 'some?' will include empty zip file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/taojoe/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #284
    
----
commit e738e27ed8a24b30143c229a3b8405271372ca23
Author: joe <ta...@gmail.com>
Date:   2014-10-07T00:26:16Z

    delete 'some?', change 'zip-contains-dir?'. make storm-core/src/clj/backtype/storm/util.clj compatible with clojure 1.6. in fact zip-contains-dir? use some? will include empty zip file.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: delete 'some?', change 'zip-contains-dir?'. ma...

Posted by taojoe <gi...@git.apache.org>.
Github user taojoe closed the pull request at:

    https://github.com/apache/storm/pull/284


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: delete 'some?', change 'zip-contains-dir?'. ma...

Posted by taojoe <gi...@git.apache.org>.
Github user taojoe commented on the pull request:

    https://github.com/apache/storm/pull/284#issuecomment-58121217
  
    in fact, zip-contains-dirs? will return true every time, 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---