You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by David Sitsky <si...@users.sourceforge.net> on 2003/08/26 23:24:29 UTC

Changing Index: line in diff to contain svn file URL

Hi,

Last week there was a thread I started in regards to possibly changing the 
"Index:" line in an svn diff to contain the full svn filename URL rather 
than just the base filename.

http://www.contactor.se/~dast/svnusers/archive-2003-08/0437.shtml

Is this going to be actioned at some stage, or has it been decided to drop 
it?

-- 
Cheers,
David


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Changing Index: line in diff to contain svn file URL

Posted by David Sitsky <si...@users.sourceforge.net>.
On Thu, 28 Aug 2003 08:43, Jack Repenning wrote:
> At 9:08 PM +0100 8/27/03, Julian Foad wrote:
> >David Sitsky wrote:
> >>Last week there was a thread I started in regards to possibly
> >>changing the "Index:" line in an svn diff to contain the full svn
> >>filename URL rather than just the base filename.
> >>
> >>http://www.contactor.se/~dast/svnusers/archive-2003-08/0437.shtml
> >>
> >>Is this going to be actioned at some stage, or has it been decided
> >>to drop it?
> >
> >...
> >It would make more sense to add an extra line corresponding to CVS's
> >"RCS file:" line.  I can see that this would be useful, though I
> >don't need it myself.
>
> I like Julian's approach (does it still work for you, David?).

This would be great.

> I think the state of the discussion is: someone (me, actually)
> clarified that you are only requesting info which is indeed available
> at client side, and was waiting for someone who knows the guts of the
> diff engine to say "oh, you're right, that info *is* available."
>
> If someone appropriate said that, I think we'd file an enhancement.
> But I think it looks like a "post-1.0" thing: your users are
> inconvenienced, but have a work-around that gets them nearly there
> (do the diffs consistently from the top of their trees, so the path
> roots are familiar).  Is that a fair impact assessment?

That is pretty fair.  I was actually a bit worried from a subversion point 
of view in changing the diff format post 1.0 release, but if that isn't a 
concern, then no worries.

Do I need to post this issue anywhere so it won't be lost in the noise, or 
has this already been done somewhere?

-- 
Cheers,
David


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Changing Index: line in diff to contain svn file URL

Posted by Jack Repenning <jr...@collab.net>.
At 9:08 PM +0100 8/27/03, Julian Foad wrote:
>David Sitsky wrote:
>>
>>Last week there was a thread I started in regards to possibly 
>>changing the "Index:" line in an svn diff to contain the full svn 
>>filename URL rather than just the base filename.
>>
>>http://www.contactor.se/~dast/svnusers/archive-2003-08/0437.shtml
>>
>>Is this going to be actioned at some stage, or has it been decided 
>>to drop it?
>
>...
>It would make more sense to add an extra line corresponding to CVS's 
>"RCS file:" line.  I can see that this would be useful, though I 
>don't need it myself.

I like Julian's approach (does it still work for you, David?).

I think the state of the discussion is: someone (me, actually) 
clarified that you are only requesting info which is indeed available 
at client side, and was waiting for someone who knows the guts of the 
diff engine to say "oh, you're right, that info *is* available."

If someone appropriate said that, I think we'd file an enhancement. 
But I think it looks like a "post-1.0" thing: your users are 
inconvenienced, but have a work-around that gets them nearly there 
(do the diffs consistently from the top of their trees, so the path 
roots are familiar).  Is that a fair impact assessment?
-- 
-==-
Jack Repenning
CollabNet, Inc.
8000 Marina Boulevard, Suite 600
Brisbane, California 94005
o: 650.228.2562
c: 408.835-8090

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Changing Index: line in diff to contain svn file URL

Posted by Julian Foad <ju...@btopenworld.com>.
David Sitsky wrote:
> 
> Last week there was a thread I started in regards to possibly changing the 
> "Index:" line in an svn diff to contain the full svn filename URL rather 
> than just the base filename.
> 
> http://www.contactor.se/~dast/svnusers/archive-2003-08/0437.shtml
> 
> Is this going to be actioned at some stage, or has it been decided to drop 
> it?

Sounds like a bad idea to make the "Index:" line gratuitously different from that produced by CVS.  If your script parses the header lines of "cvs diff" or "svn diff" output, then it is likely that others are doing so too, and changing the format would break them.

It would make more sense to add an extra line corresponding to CVS's "RCS file:" line.  I can see that this would be useful, though I don't need it myself.

- Julian


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org