You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Vinod K V (JIRA)" <ji...@apache.org> on 2009/10/14 08:45:31 UTC
[jira] Created: (MAPREDUCE-1108) Modify test-patch.sh to verify
that the number of findBugs warning is always zero
Modify test-patch.sh to verify that the number of findBugs warning is always zero
---------------------------------------------------------------------------------
Key: MAPREDUCE-1108
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1108
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: build
Reporter: Vinod K V
HADOOP-5661 and MAPREDUCE-769 involve going through pains to make sure findBugs warnings become zero. All that effort would be a waste if patches keep ignoring these warnings.
We should modify the Hudson test-patch.sh script to always verify that the findBugs warnings are zero in number. It should scream when the warnings go above zero level and make sure trunk is always at zero findBugs warnings.
And to help contributors about what to do when an un-ignorable warning is spelt out by test-patch.sh, we should modify the output of test-patch.sh to point to _src/test/findbugsExcludeFile.xml_ for suppressing any warnings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1108) Modify test-patch.sh to verify
that the number of findBugs warning is always zero
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765652#action_12765652 ]
gary murry commented on MAPREDUCE-1108:
---------------------------------------
{quote}And to help contributors about what to do when an un-ignorable warning is spelt out by test-patch.sh, we should modify the output of test-patch.sh to point to src/test/findbugsExcludeFile.xml for suppressing any warnings.{quote}
I assume you meant "what to do when a warning is either not fixable or incorrect", not "un-ignorable".
> Modify test-patch.sh to verify that the number of findBugs warning is always zero
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1108
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1108
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Reporter: Vinod K V
>
> HADOOP-5661 and MAPREDUCE-769 involve going through pains to make sure findBugs warnings become zero. All that effort would be a waste if patches keep ignoring these warnings.
> We should modify the Hudson test-patch.sh script to always verify that the findBugs warnings are zero in number. It should scream when the warnings go above zero level and make sure trunk is always at zero findBugs warnings.
> And to help contributors about what to do when an un-ignorable warning is spelt out by test-patch.sh, we should modify the output of test-patch.sh to point to _src/test/findbugsExcludeFile.xml_ for suppressing any warnings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1108) Modify test-patch.sh to verify
that the number of findBugs warning is always zero
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765886#action_12765886 ]
Vinod K V commented on MAPREDUCE-1108:
--------------------------------------
bq. I assume you meant "what to do when a warning is either not fixable or incorrect", not "un-ignorable".
Yes, correct. I meant not-fixable.
> Modify test-patch.sh to verify that the number of findBugs warning is always zero
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1108
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1108
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Reporter: Vinod K V
>
> HADOOP-5661 and MAPREDUCE-769 involve going through pains to make sure findBugs warnings become zero. All that effort would be a waste if patches keep ignoring these warnings.
> We should modify the Hudson test-patch.sh script to always verify that the findBugs warnings are zero in number. It should scream when the warnings go above zero level and make sure trunk is always at zero findBugs warnings.
> And to help contributors about what to do when an un-ignorable warning is spelt out by test-patch.sh, we should modify the output of test-patch.sh to point to _src/test/findbugsExcludeFile.xml_ for suppressing any warnings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1108) Modify test-patch.sh to verify
that the number of findBugs warning is always zero
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765428#action_12765428 ]
Vinod K V commented on MAPREDUCE-1108:
--------------------------------------
As noted by others, this would also speed up the test-patch.sh process as we will just to need to find the number of warnings introduced by the patch.
> Modify test-patch.sh to verify that the number of findBugs warning is always zero
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1108
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1108
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Reporter: Vinod K V
>
> HADOOP-5661 and MAPREDUCE-769 involve going through pains to make sure findBugs warnings become zero. All that effort would be a waste if patches keep ignoring these warnings.
> We should modify the Hudson test-patch.sh script to always verify that the findBugs warnings are zero in number. It should scream when the warnings go above zero level and make sure trunk is always at zero findBugs warnings.
> And to help contributors about what to do when an un-ignorable warning is spelt out by test-patch.sh, we should modify the output of test-patch.sh to point to _src/test/findbugsExcludeFile.xml_ for suppressing any warnings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1108) Modify test-patch.sh to verify
that the number of findBugs warning is always zero
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765604#action_12765604 ]
Konstantin Boudnik commented on MAPREDUCE-1108:
-----------------------------------------------
There was another JIRA (can't find it right now) on increasing javac's warning level to make sure we catch those.
> Modify test-patch.sh to verify that the number of findBugs warning is always zero
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1108
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1108
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Reporter: Vinod K V
>
> HADOOP-5661 and MAPREDUCE-769 involve going through pains to make sure findBugs warnings become zero. All that effort would be a waste if patches keep ignoring these warnings.
> We should modify the Hudson test-patch.sh script to always verify that the findBugs warnings are zero in number. It should scream when the warnings go above zero level and make sure trunk is always at zero findBugs warnings.
> And to help contributors about what to do when an un-ignorable warning is spelt out by test-patch.sh, we should modify the output of test-patch.sh to point to _src/test/findbugsExcludeFile.xml_ for suppressing any warnings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.