You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/25 08:22:24 UTC
[GitHub] [doris] morrySnow opened a new pull request, #13647: [enhancement](chore) Enhance build script compatibility
morrySnow opened a new pull request, #13647:
URL: https://github.com/apache/doris/pull/13647
# Proposed changes
1. build fe-common when build java-udf
2. add jvm environment parameter '-Dos.arch=x86_64' when build fe on MacOS
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13647: [enhancement](chore) build fe-common when build java-udf
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13647:
URL: https://github.com/apache/doris/pull/13647#issuecomment-1290563393
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13647: [enhancement](chore) build fe-common when build java-udf
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13647:
URL: https://github.com/apache/doris/pull/13647#issuecomment-1290501846
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3319291572") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 459:
"${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} ${MVN_PARAMS}
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
"${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} "${MVN_PARAMS}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build.sh.orig
+++ build.sh
@@ -454,7 +454,7 @@
fi
MVN_PARAMS="-DskipTests"
if [[ "$(uname -s)" = 'Darwin' ]]; then
- MVN_PARAMS="${MVN_PARAMS} -Dos.arch=x86_64"
+ MVN_PARAMS="${MVN_PARAMS} -Dos.arch=x86_64"
fi
"${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} ${MVN_PARAMS}
cd "${DORIS_HOME}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #13647: [enhancement](chore) Enhance build script compatibility
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #13647:
URL: https://github.com/apache/doris/pull/13647#issuecomment-1290192482
already fixed by #13571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13647: [enhancement](chore) build fe-common when build java-udf
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13647:
URL: https://github.com/apache/doris/pull/13647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #13647: [enhancement](chore) build fe-common when build java-udf
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #13647:
URL: https://github.com/apache/doris/pull/13647#discussion_r1004626996
##########
build.sh:
##########
@@ -350,6 +350,7 @@ if [[ "${BUILD_SPARK_DPP}" -eq 1 ]]; then
modules+=("spark-dpp")
fi
if [[ "${BUILD_JAVA_UDF}" -eq 1 ]]; then
+ modules+=("fe-common")
Review Comment:
```suggestion
if [[ "${BUILD_FE}" -eq 0 ]]; then
modules+=("fe-common")
modules+=("fe-core")
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #13647: [enhancement](chore) Enhance build script compatibility
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #13647:
URL: https://github.com/apache/doris/pull/13647#discussion_r1004163133
##########
build.sh:
##########
@@ -451,7 +452,11 @@ if [[ "${FE_MODULES}" != '' ]]; then
if [[ "${CLEAN}" -eq 1 ]]; then
clean_fe
fi
- "${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} -DskipTests
+ MVN_PARAMS="-DskipTests"
+ if [[ "$(uname -s)" = 'Darwin' ]]; then
+ MVN_PARAMS="${MVN_PARAMS} -Dos.arch=x86_64"
+ fi
Review Comment:
It seems that we don't need this option `-Dos.arch=x86_64` anymore. See #13571.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13647: [enhancement](chore) build fe-common when build java-udf
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13647:
URL: https://github.com/apache/doris/pull/13647#issuecomment-1290519787
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3319388203") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 459:
"${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} ${MVN_PARAMS}
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
"${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} "${MVN_PARAMS}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build.sh.orig
+++ build.sh
@@ -454,7 +454,7 @@
fi
MVN_PARAMS="-DskipTests"
if [[ "$(uname -s)" = 'Darwin' ]]; then
- MVN_PARAMS="${MVN_PARAMS} -Dos.arch=x86_64"
+ MVN_PARAMS="${MVN_PARAMS} -Dos.arch=x86_64"
fi
"${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} ${MVN_PARAMS}
cd "${DORIS_HOME}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #13647: [enhancement](chore) build fe-common when build java-udf
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #13647:
URL: https://github.com/apache/doris/pull/13647#discussion_r1004626996
##########
build.sh:
##########
@@ -350,6 +350,7 @@ if [[ "${BUILD_SPARK_DPP}" -eq 1 ]]; then
modules+=("spark-dpp")
fi
if [[ "${BUILD_JAVA_UDF}" -eq 1 ]]; then
+ modules+=("fe-common")
Review Comment:
```suggestion
if [[ "${BUILD_FE}" -eq 0 ]]; then
modules+=("fe-common")
modules+=("fe-core")
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13647: [enhancement](chore) build fe-common when build java-udf
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13647:
URL: https://github.com/apache/doris/pull/13647#issuecomment-1290563480
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13647: [enhancement](chore) build fe-common when build java-udf
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13647:
URL: https://github.com/apache/doris/pull/13647#issuecomment-1291159840
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow closed pull request #13647: [enhancement](chore) Enhance build script compatibility
Posted by GitBox <gi...@apache.org>.
morrySnow closed pull request #13647: [enhancement](chore) Enhance build script compatibility
URL: https://github.com/apache/doris/pull/13647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org