[GitHub] [flink-table-store] tsreaper commented on a change in pull request #7: [FLINK-25643] Introduce Predicate to table store

[GitBox <gi...@apache.org>]

tsreaper commented on a change in pull request #7:
URL: https://github.com/apache/flink-table-store/pull/7#discussion_r784594032



##########
File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/predicate/Equal.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.file.predicate;
+
+import org.apache.flink.table.store.file.stats.FieldStats;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/** A {@link Predicate} to eval equal. */
+public class Equal implements Predicate {
+
+    private final int index;
+
+    private final Literal literal;
+
+    public Equal(int index, Literal literal) {
+        this.index = index;
+        this.literal = checkNotNull(literal);
+    }
+
+    @Override
+    public boolean test(Object[] values) {
+        Object field = values[index];
+        return field != null && literal.compareValueTo(field) == 0;
+    }
+
+    @Override
+    public boolean test(long rowCount, FieldStats[] fieldStats) {
+        FieldStats stats = fieldStats[index];
+        if (rowCount == stats.nullCount()) {
+            return false;
+        }
+        return literal.compareValueTo(stats.minValue()) >= 0
+                && literal.compareValueTo(stats.maxValue()) <= 0;

Review comment:
       `stats.minValue()` and `stats.maxValue()` can be null even for comparable types (see current implementation of `SstFile.RollingFile#finish`. Please deal with this case and add more tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org